[chrispader]

In expense views, message-edit scrolling currently assumes the main report action list is inverted. MoneyRequestReportActionsList orders items chronologically, so editing its newest message can ask the wrong list position to stay visible. This WIP extraction makes message-edit scrolling list-aware while preserving existing report behavior.

@roryabraham @dmkt9

Explanation of Change

The existing report action position context now carries both the action index and whether the action is newest, so each list declares its own ordering semantics. MoneyRequestReportActionsList also provides a separate list-level callback that scrolls to its newest position, while the inverted main report list keeps the existing report scroll manager fallback.

This is layer 2 of the seven-part LegendList series. Review order is #100732 → this PR → #100884 → #100733 → #100740 → #100734 → #100736. The branches are maintained with GH Stacks in the Margelo fork; because GitHub does not support linking cross-fork heads into an upstream Stack, each upstream PR targets Expensify/App:main and records the dependency order here.

Fixed Issues

$ #98994
PROPOSAL:

No approved proposal is linked.

Tests

1. Open an expense report with several report actions.
2. Edit and save the newest comment.
3. Verify the edited comment remains visible and the list stays at its newest position.
4. Edit an older comment and verify the list does not jump to its newest position.
5. Repeat the newest- and older-comment checks in a regular chat and verify its existing scroll behavior is unchanged.
6. Verify that no errors appear in the JS console.

• Verify that no errors appear in the JS console

Offline tests

1. Open a cached expense report, then go offline.
2. Edit the newest comment and verify it remains visible after saving.
3. Edit an older comment and verify the list does not jump to its newest position.
4. Return online and verify the pending edit synchronizes without changing the scroll position unexpectedly.

QA Steps

Same as Tests and Offline tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen_Recording_20260914_113442_Expensify.Debug.legendlist.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-09-14.at.10.48.28.mov

MacOS: Chrome / Safari

Screen.Recording.2026-09-14.at.11.21.12.mov

[melvin-bot]

@dmkt9 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-11T10:30:01.084468Z	a796f48	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[dylanexpensify]

Performance related vs pure product update. Input not needed

[chrispader]

@roryabraham @dmkt9 this is ready for review!

[dmkt9]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mp4

Android: mWeb Chrome

iOS: HybridApp

ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

[dmkt9]

LGTM

[github-actions]

🚧 roryabraham has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #100883.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-392446c-6350815-5d032612d8b14cacadde37bffb149a48d6055f6d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-392446c-6350815-ea12dcf1cb3596bcc40b75b9dac1e94be9c7bb44/index.html

Web 🕸️
https://100883.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.80-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

🤖 No help site changes are required for this PR. I did not create a docs PR.

Why

This PR only changes internal scroll mechanics after a message edit is saved. It adds no user-facing copy, no new setting, no new button, and no change to any documented step.

The relevant help article is Chat Features and Moderation Tools. Its Edit or Delete Messages section documents this flow:

1. Open a chat.
2. Right-click (or hover over) a message.
3. Select Edit comment or Delete comment.
4. If editing, modify the message inline and press Enter to save.

Every one of those steps is still accurate after this PR. The article documents how to edit a message, not where the list scrolls afterwards — and scroll position is the only thing this PR touches.

What the diff actually changes

The change replaces a hardcoded "index 0 means newest" assumption with an explicit, list-declared ordering:

• src/pages/inbox/report/ReportActionIndexContext.tsx — the context value goes from a bare number to {index, isNewest}, plus a new ReportActionScrollToNewestContext so each list can supply its own scroll-to-newest callback.
• src/pages/inbox/report/ReportActionItemMessageEdit.tsx:253-254 — shouldScrollToLastMessage: index === 0 becomes shouldScrollToLastMessage: isNewest.
• src/components/MoneyRequestReportView/MoneyRequestReportActionsList.tsx — the chronological expense list now reports isNewest as the last index and passes its own scrollToBottom.
• src/pages/inbox/report/ReportActionsList.tsx — the inverted main report list keeps isNewest: index === 0 and the existing scroll manager fallback.

The remaining three files are tests. Net user-visible effect: editing the newest comment in an expense report now keeps that comment visible, which is what the help site already implies should happen. It restores expected behavior rather than introducing new behavior worth documenting.

Since no docs changes were needed, there is no help site PR to link or mark Ready for review. If you'd still like an article updated — for example, to call out edit behavior in expense reports specifically — reply with @MelvinBot and what you want covered, and I'll draft it.

---

view run

[OSBotify]

🚀 Deployed to production by https://github.com/luacmartins in version: 9.4.80-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Bundle Size Analysis (Sentry):

• Android