Skip to content

[LegendList 4/7] feat: migrate report actions to chronological LegendList - #100733

Open
chrispader wants to merge 68 commits into
Expensify:mainfrom
margelo:@chrispader/feat/legend-list-report-actions
Open

chrispader wants to merge 68 commits into
Expensify:mainfrom
margelo:@chrispader/feat/legend-list-report-actions

Conversation

@chrispader

@chrispader chrispader commented Sep 9, 2026 •

Copy link
Copy Markdown
Contributor

The report-actions list currently uses inversion, so rendering order and scroll coordinates differ from chronological message order. This PR moves the main chat list to LegendList and updates pagination, unread tracking, message editing, recycling, and initial loading behavior to work with chronological data.

@roryabraham @dmkt9

@Expensify/design Please review the initial chat-loading skeleton shown below.

Explanation of Change

This is layer 4 of the seven-part LegendList and chat pagination stack. It migrates ReportActionsList to chronological LegendList data through a direct {LegendList} import from @legendapp/list/react-native, updates the shared action-list ref contract, preserves cached pages during hydration, and includes the Android anchor patch. It also covers pagination thresholds, targeted scrolling, unread tracking, live-tail updates, badge targets, message editing, and recycled rows. Other FlashList consumers remain unchanged, and layer 5 adds the separate loading indicators and pagination-scroll behavior.

Initial loading now uses one shared, bottom-padded skeleton cover across the Inbox and Search expense-report entry paths. The cover remains visible while the initial request is pending and until the current LegendList viewport reports that it loaded. LegendList also keeps newly assigned rows hidden until native measurement finishes, which prevents estimated off-screen rows such as the chat start message from briefly overlapping visible content. A terminal initial-load failure can clear the cover instead of leaving it stuck.

The review follow-up restores onStartReached so short chats can load older pages before the viewport becomes scrollable, names the comment-size recycling thresholds, and keeps newest-message edits in large money reports on the list's indexed bottom-scroll path. The Reassure scenario now has a LegendList-specific name because the LegendList Jest mock eagerly renders its supplied data while the previous FlashList harness used virtualization; this establishes a renderer-specific baseline instead of comparing incompatible test harnesses. Layer 1 is now merged, and this branch includes its final edge-callback latch changes plus the latest main.

Message-edit scrolling from #100883 and the shared loading-skeleton cover from #100884 are now on main. This branch keeps the LegendList-specific integration, while the shared changes from those PRs have dropped out of this diff.

Review order: 1. Foundation → 2. Message edit scrolling → 3. Loading skeleton consistency → 4. Report actions → 5. Chat pagination loading → 6. Remaining FlashList consumers → 7. Remaining FlatList consumers and restrictions. Review and merge the layers in this order.

Fixed Issues

$ #98994
$ #99202

This PR is part of the migration split from #98270. No approved proposal is linked.

Tests

  1. Sign in with a high-traffic account and open a chat with enough history to paginate in both directions. Test both a cold open and a warm open, including an expense chat. Verify there is one consistently positioned loading skeleton with bottom padding before the content appears.
  2. Scroll through older and newer pages. Verify messages remain in chronological order, consecutive actions stay grouped, and loading a page does not move the visible message.
  3. Open links to older, newest, and unread messages, including a target at the beginning of the loaded data. Verify the target appears in the correct position, the unread marker stays with the correct message, and the chat start message never overlaps visible content while the list is measuring.
  4. Stay at the bottom while another account sends a message. Verify the list follows the new message.
  5. Scroll up into history while another account sends a message. Verify the list keeps the current reading position instead of jumping to the new message.
  6. Edit recent and older messages, and receive a streamed Concierge response. Verify edits and streamed text stay attached to the correct message.
  7. Send messages containing URLs, single-line code, code blocks, quotes, headings, bold, strikethrough, and italic text. Verify every format renders correctly before and after scrolling the row off-screen and back.
  8. Scroll repeatedly through text, image, and PDF rows. Verify recycled rows do not carry content, selection, preview, or loading state into another message.
  9. Open a direct chat link while signed in, then open the same link while signed out and sign in. Verify the requested chat opens and scrolling works in both flows.
  10. Open a short chat whose loaded actions do not fill the viewport but which has older history. Verify older pages load until the viewport can scroll or the oldest action is reached.
  11. Open a large money report, edit its newest message, and save or cancel the edit. Verify the list returns to the newest action without landing on blank estimated space.
  12. Cause the initial report request to fail, then retry it. Verify the loading cover clears after the terminal failure and the report can load normally after the retry.
  • Verify that no errors appear in the JS console

Offline tests

  1. Open a chat online so its history is cached, disconnect the network, and reopen the chat. Verify the cached messages remain visible in chronological order and existing message grouping is unchanged.
  2. While offline, scroll to an unloaded edge of the cached history. Verify the visible messages stay in place and the list does not enter a broken or empty state.
  3. Reconnect while history is loading. Verify the cached page remains visible until hydration completes, the missing page loads, and the visible message does not jump.
  4. Disconnect during pagination, reconnect, and retry by scrolling to the same edge. Verify pagination recovers and the requested messages appear once without duplicates.

QA Steps

Same as Tests and Offline tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

I reviewed every item for this PR. A checked conditional item means I verified it or determined that it does not apply. I attached the available native evidence below; Android screen recordings are still TBD, and web recordings are deferred. The checked recordings item records that review and the available evidence, not that every platform has a video.

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

iOS: Native

Cold chat open and initial loading

FlashList is on the left and LegendList is on the right. FlashList leaves the report body blank during loading; LegendList shows the report-action skeleton before messages appear.

LegendListLoadingSkeletonVsFlashList.mp4

Cold expense-chat open

FlashList is on the left and LegendList is on the right. Both progress from the loading skeleton to an expense preview and its surrounding report actions.

ExpenseChatCold.mp4

Warm expense-chat open

FlashList is on the left and LegendList is on the right. Both open the cached expense preview and report actions from the inbox.

ExpenseChatWarm.mp4

Warm chat open

Side-by-side opens of the same cached chat, ending on the same report-action history. The implementations are not labeled in this recording.

LegendListWarmReportOpen.mp4
Android: Native

Cold chat open and initial loading

FlashList is on the left and LegendList is on the right. FlashList leaves the report body blank during loading; LegendList shows the report-action skeleton before messages appear.

ColdOpenLoading.mp4

Cold expense-chat open

FlashList is on the left and LegendList is on the right. Both progress from the loading skeleton to an expense preview and its surrounding report actions.

Android screen recording TBD.

Warm expense-chat open

FlashList is on the left and LegendList is on the right. Both open the cached expense preview and report actions from the inbox.

Android screen recording TBD.

Warm chat open

Side-by-side opens of the same cached chat, ending on the same report-action history. The implementations are not labeled in this recording.

Android screen recording TBD.

Web recordings are deferred.

@chrispader
chrispader force-pushed the @chrispader/feat/legend-list-report-actions branch from 1bac411 to c067b0c Compare September 9, 2026 18:27
@chrispader
chrispader force-pushed the @chrispader/feat/legend-list-report-actions branch from c067b0c to e784ebe Compare September 9, 2026 20:24
@chrispader chrispader changed the title feat: migrate report actions to chronological LegendList [LegendList 2/5] feat: migrate report actions to chronological LegendList Sep 9, 2026
@chrispader
chrispader marked this pull request as ready for review September 10, 2026 09:44
@chrispader
chrispader requested review from a team as code owners September 10, 2026 09:44
@melvin-bot
melvin-bot Bot requested review from TaduJR and garrettmknight and removed request for a team and TaduJR September 10, 2026 09:44
@melvin-bot

melvin-bot Bot commented Sep 10, 2026

Copy link
Copy Markdown

@TaduJR Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from a team and removed request for a team September 10, 2026 09:44
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-10T10:07:15.590070Z f616302 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Sep 10, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
...omponents/Composer/implementation/index.native.tsx 90.19% <ø> (-0.19%) ⬇️
src/components/FlashList/index.tsx 100.00% <100.00%> (ø)
src/components/FlatList/FlatList/index.ios.tsx 88.88% <100.00%> (-1.59%) ⬇️
src/components/FlatList/FlatList/index.tsx 50.98% <100.00%> (+50.98%) ⬆️
...c/components/KeyboardDismissibleFlatList/index.tsx 100.00% <100.00%> (+100.00%) ⬆️
...mponents/LegendList/allowLegendListItemOverflow.ts 100.00% <100.00%> (ø)
...equestReportView/MoneyRequestReportActionsList.tsx 96.84% <ø> (ø)
...stReportView/MoneyRequestReportTransactionList.tsx 72.05% <ø> (ø)
...equestReportView/MoneyRequestReportUnifiedList.tsx 12.63% <ø> (ø)
...nents/ReportActionItem/ReceiptPDFOverlay/index.tsx 90.19% <100.00%> (ø)
... and 30 more
... and 85 files with indirect coverage changes

Comment thread src/pages/inbox/report/ReportActionsList.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f616302cdb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/pages/inbox/report/ReportActionsList.tsx
Comment thread src/pages/inbox/report/ReportActionCompose/useEditMessage.ts Outdated
@chrispader chrispader changed the title [LegendList 2/5] feat: migrate report actions to chronological LegendList [HOLD on #100732][LegendList 2/5] feat: migrate report actions to chronological LegendList Sep 10, 2026
@chrispader
chrispader force-pushed the @chrispader/feat/legend-list-report-actions branch from f616302 to 2a3323a Compare September 10, 2026 11:11
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@chrispader chrispader changed the title [HOLD on #100732][LegendList 2/5] feat: migrate report actions to chronological LegendList [HOLD on #100732] [LegendList 2/5] feat: migrate report actions to chronological LegendList Sep 10, 2026
@dmkt9

dmkt9 commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

@chrispader I found some bugs here: #100733 (comment). I'm still testing on my side and will report any additional bugs I find. Sorry for not being able to report them all at once.

@dmkt9

dmkt9 commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

@dmkt9 do you have a video for that? I've just checked and for me it works normally.

Sure. Here is the record:

@dmkt9 did you record this on the latest commit or the commit that you previously did the review on? I could personally reproduce this issue on neither commits.

There's a good chance this is fixed now, could you verify again? 🙌🏼

Yes, I can still reproduce it. If you're still unable to reproduce it, I think we can request an adhoc build and test it on a physical device

Clearing the linked-action route after sending remounted the report content and LegendList, briefly restoring the loading skeleton and resetting composer state. Keep the report content mounted while resetting only the link checks, and remount the list only when opening a linked action or completing initial hydration.
@chrispader

chrispader commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor Author

Chris's AI wingmate checking in on his behalf. 🤖

Six fixes for the latest review findings have been committed and pushed to this PR through 779eaacf57b. Below is how those changes address the reported issues. Final verification of the broader recordings is still incomplete.

  1. The review reported:

    hides the "New" marker

    footer stays below the screen

    Tall unread messages now open at the "New" marker. Bottom alignment applies only to an explicitly linked final message. Removing the explicit zero offset also lets LegendList include the footer, such as Concierge's thinking indicator, when positioning that final message.

  2. The review reported:

    keeps pulling the reader back to the bottom

    The original report also described:

    jumps back to the bottom

    Show History and deleting the latest message no longer let a pending layout correction pull the reader back to the bottom after they scroll away. Starting a drag cancels the queued correction and clears the history restore flag. The history callback checks those flags again before scrolling. LegendList follows data changes, while the cancellable correction handles layout changes. The Android delete-then-scroll flow passed on a simulator; Show History with substantial Concierge history still needs final testing.

  3. The original report described:

    hover style flickers

    The custom scroll view now emits scroll events every 16 ms. Previously, web received only the first and last events, allowing hover controls to reappear during an ongoing scroll. Continuous events keep hover suppression active while scrolling. The full web hover flow still needs final testing.

  4. The original Android report described:

    entire list flashes

    The initial skeleton stays visible until LegendList's initial positioning finishes, through onReady rather than onLoad. This keeps estimated row positions covered and preserves the intended skeleton above the blank space while the chat settles. It addresses flashes during initial positioning; the broader Android recording still needs confirmation.

  5. The review reported:

    next reply isn't followed

    End following resumes when the reader scrolls from a linked message to the latest messages. An initial linked target no longer permanently blocks later layout corrections, so growing content can remain visible once the reader reaches the bottom. This complements the footer-alignment change in item 1. The full Concierge flow still needs final testing.

  6. The original report described:

    loading state appears

    keyboard appears briefly

    Sending from a linked-message route keeps the report content, list, and composer mounted. The missing-message guard now resets its checks independently, and clearing a link preserves the list's identity. Opening a link still starts fresh positioning, including reopening the same message. This removes the reproduced skeleton flash and composer remount after sending. That flow passed on iOS and Android simulators with the keyboard staying visible. Sending a message containing a URL and the remaining keyboard/navigation transitions from the recordings still need final verification.

On October 1, all 133 focused regression tests and the required local checks passed. The linked-message send flow passed on both iOS and Android simulators without the skeleton flash, and the keyboard stayed visible. The Android delete-then-scroll flow also stayed on older messages. Linked targets below long comments and editing a long expense-chat comment passed with local test fixtures.

Chris still needs to do final testing, including the full web PDF/hover flows, Concierge with substantial history, and the remaining keyboard/navigation transitions from the review recordings. Those broader reports are not all verified yet, and the performance benchmark request remains open.

@chrispader

Copy link
Copy Markdown
Contributor Author

Still working on the remaining issues 👀

Suppress hover throughout scrolling in the shared list wrappers after the chronological migration. Restore report-list render benchmarks and exercise the production start-reached pagination callback.
@chrispader

chrispader commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor Author

Chris's AI toolbox buddy here. 🤖

First review by @dmkt9

If you scroll up immediately after deleting a comment, the list jumps back to the bottom:

✅ Fixed!

Screen.Recording.2026-10-09.at.13.00.27.mov

__

* The report always shows the loading state whenever it's opened. The same happens when opening a thread and returning to the parent chat. * Android: The submitted expense isn't positioned correctly within the viewport when the report is opened. The highlighted comment also briefly flashes when returning from a thread to the parent chat.

  • iOS: When the highlighted comment is the last item, it isn't displayed within the viewport.

✅ Fixed!

Screen.Recording.iPhone.17.Pro.09-10-2026.at.12.58.32.mp4

Second review by @dmkt9

On android, the entire list flashes:

✅ Fixed!

Screen_Recording_20261009_131209_Expensify.Dev.mp4

Similar to a previously reported bug: (earlier comment). This time, the bug is more noticeable.

Steps to reproduce:

  1. Delete the latest item.
  2. Once the latest item disappears, scroll up.

✅ Fixed!

Screen.Recording.2026-10-09.at.13.00.27.mov

The hover style flickers on items when scrolling with the mouse:

✅ Fixed!

Screen.Recording.2026-10-09.at.13.16.00.mov

The highlighted item position isn't reliable when opening the chat:

✅ Fixed!

Screen_Recording_20261009_131209_Expensify.Dev.mp4

The keyboard appears briefly:

✅ Fixed!

Screen_Recording_20261009_140222_Expensify.Dev.mp4

The keyboard doesn't appear when editing a long comment:

✅ Fixed!

Screen_Recording_20261009_142047_Expensify.Dev.mp4

On Android, the highlighted item is out of the viewport if there is a long comment above it:

✅ Fixed!

Screen_Recording_20261009_152613_Expensify.Dev.mp4

Similarly, on web, the highlighted item is out of the viewport when it's a PDF preview:

✅ Fixed!

Screen.Recording.2026-10-09.at.13.39.01.mov

The loading state appears after sending a link message:

✅ Fixed!

Screen.Recording.2026-10-09.at.13.43.17.mov

Latest MelvinBot review

Fixed Show History pulling the reader back to the bottom, restored the New marker for tall unread final messages, and preserved footer positioning for linked final messages, with regression tests for these cases. All local fixes, including late-layout linked-message positioning and the report-switch/reconnect edge cases, are now pushed through d25f5b6.

🟡 1. Show History keeps pulling the reader back to the bottom

🟡 2. A tall unread newest message now opens at its end, which hides the "New" marker

⚪ 3. viewOffset: 0 disables LegendList's end-of-content handling


Follow ups

@chrispader

Copy link
Copy Markdown
Contributor Author

@dmkt9 @roryabraham all previous issues have been addressed! Unless there are any new issues, this PR should be ready to go.

@roryabraham could you please trigger an ad-hoc build on this?

@dmkt9

dmkt9 commented Oct 13, 2026

Copy link
Copy Markdown
Contributor
Fixed ✅

* The report always shows the loading state whenever it's opened. The same happens when opening a thread and returning to the parent chat.
* Android: The submitted expense isn't positioned correctly within the viewport when the report is opened. The highlighted comment also briefly flashes when returning from a thread to the parent chat.
* iOS: When the highlighted comment is the last item, it isn't displayed within the viewport.

Details
bug1.mp4
---

Sometimes, the last item being edited isn't scrolled into the viewport:

Details https://github.com/user-attachments/assets/0c461e30-fcc8-450a-847b-29a837e2115d

Clicking the Show History button in the Concierge chat scrolls to the beginning of the report. Additionally, if it doesn't scroll to the beginning of the report, the scroll position jumps slightly.

Details **Steps to reproduce:**
  1. Refresh the app while in the Concierge chat.
  2. Open a chat with an active need to do.
  3. Go back to the Concierge chat.
  4. Click the Show History button.
bug4.mp4

On android, the entire list flashes:

Details
bug1.mp4

The list jumps back to the bottom:

Similar to a previously reported bug: #100733 (comment). This time, the bug is more noticeable.

Steps to reproduce:

1. Delete the latest item.
2. Once the latest item disappears, scroll up.

Details
bug2.mp4

The hover style flickers on items when scrolling with the mouse:

Details
bug3.mp4

The highlighted item position isn't reliable when opening the chat:

Details
bug4.mp4

Similarly, on web, the highlighted item is out of the viewport when it's a PDF preview:

Details
bug71.mp4

The loading state appears after sending a link message:

Details
bug8.mp4

Remaining ⚠️

The keyboard appears briefly:

Details
bug5.mp4

The keyboard doesn't appear when editing a long comment:

Details
bug6.mp4

On Android, the highlighted item is out of the viewport if there is a long comment above it:

Details
bug7.mp4

Unable to test due to a new bug:

The app automatically navigates back to the Home screen when "Reply in thread".

Details
bug2.mp4

New bug ❗

Android: The highlighted item scrolls down and then back up:

Details
bug1.mp4

Android: Scrolling slightly right after the loading state disappears causes the list to jump:

Details
bug3.mp4

Web: The "Submit" badge needs to be clicked multiple times (sometimes 3–4 times) to scroll to the highlighted item.

Sometimes, the top of the highlighted item or the bottom of the last item in the list is obscured.

Details
bug4.mp4

@chrispader

chrispader commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor Author

@dmkt9 I cannot reproduce most of the reported issues. I've tested and recorded screen recordings for all of these issues on both a physical Samsung Galaxy S10e and Android Pixel 9 emulator running Android 17.

Could you please try to reproduce these on a physical device or a different emulator? I suspect the issues are related to your specific emulator setup or your build is invalid.

@dmkt9 please let me know exactly which device/model and Android version your testing on. Also this seems like it's all on an emulator, right?


Remaining ⚠️

The keyboard appears briefly:

❓ I still cannot reproduce this issue. I have pretty much the same list content as in your screen recording, last message is a string, before that a PDF and some more messages.

Screen recordings

Pixel 9 emulator

android.webm

Samsung Galaxy S10e

Screen_Recording_20261019_152346_New.Expensify.Dev.copy.mp4

The keyboard doesn't appear when editing a long comment:

✅ Fixed! Not reproducible anymore on emulator nor physical Android device.

Screen recordings

Pixel 9 emulator

longComment.webm

Samsung Galaxy S10e

Screen_Recording_20261019_165518_Expensify.Dev.mp4

On Android, the highlighted item is out of the viewport if there is a long comment above it:

❓ Also not reproducible. Some of the issues related to showing the linked message in the viewport all seem related, but they should have all been fixed.

Screen recordings

Pixel 9 emulator

linking.webm

Samsung Galaxy S10e

Screen_Recording_20261019_174958_Expensify.Dev.mp4

Unable to test due to a new bug:

@dmkt9 Do you mean, you could not reach this next issue, so this is an old recording? Or what issue could you not test?

The app automatically navigates back to the Home screen when "Reply in thread".

❓ Not reproducible.

Screen recordings

Pixel 9 emulator

navigateBack.webm

Samsung Galaxy S10e

Screen_Recording_20261019_183852_Expensify.Dev.mp4

New bug ❗

Android: The highlighted item scrolls down and then back up:

✅ As mentioned above, all issues related to the initial scroll position should be fixed. Let me know if it is still reproducible on another emulator and physical Android device.

Screen recordings

Pixel 9 emulator

initialExpense.webm

Samsung Galaxy S10e

Screen_Recording_20261019_183340_Expensify.Dev.mp4

bug1.mp4
Android: Scrolling slightly right after the loading state disappears causes the list to jump:

❓ Not reproducible. In your screen recordings it looked like this might be related to the initial rendering of a chat, where the linked item might have jumped around, because newer messages were loading at that time, but i couldn't reproduce this either. I attached a screen recording for both warm and cold report open.

Screen recordings

Pixel 9 emulator

Warm report open

scrollRight.webm

Cold report open (after clearing Onyx)

scrollFresh.webm

Samsung Galaxy S10e

Screen_Recording_20261019_185531_Expensify.Dev.mp4

bug3.mp4
Web: The "Submit" badge needs to be clicked multiple times (sometimes 3–4 times) to scroll to the highlighted item.
Sometimes, the top of the highlighted item or the bottom of the last item in the list is obscured.

✅ These should be fixed!

Screen recordings

Web

Screen.Recording.2026-10-19.at.17.59.37.mov

@chrispader

Copy link
Copy Markdown
Contributor Author

I've now addressed all of the remaining issues from @dmkt9. Some of them i could not reproduce. @dmkt9 please make sure to test on a different emulator and/or a physical device.

After these issues we should be good to go.

const isInLandscapeMode = useIsInLandscapeMode();

// Android keeps the input focused when the keyboard is dismissed with the back button/gesture.
useBlurOnKeyboardHide(textInputRef);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain why we need this change? If the composer doesn't lose focus, the keyboard will appear when we close the modal and return to the chat

@dmkt9

dmkt9 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor
Fixed ✅

* The report always shows the loading state whenever it's opened. The same happens when opening a thread and returning to the parent chat.
* Android: The submitted expense isn't positioned correctly within the viewport when the report is opened. The highlighted comment also briefly flashes when returning from a thread to the parent chat.
* iOS: When the highlighted comment is the last item, it isn't displayed within the viewport.

Details
bug1.mp4
---

Sometimes, the last item being edited isn't scrolled into the viewport:

Details https://github.com/user-attachments/assets/0c461e30-fcc8-450a-847b-29a837e2115d

Clicking the Show History button in the Concierge chat scrolls to the beginning of the report. Additionally, if it doesn't scroll to the beginning of the report, the scroll position jumps slightly.

Details **Steps to reproduce:**
  1. Refresh the app while in the Concierge chat.
  2. Open a chat with an active need to do.
  3. Go back to the Concierge chat.
  4. Click the Show History button.
bug4.mp4

On android, the entire list flashes:

Details
bug1.mp4

The list jumps back to the bottom:

Similar to a previously reported bug: #100733 (comment). This time, the bug is more noticeable.

Steps to reproduce:

1. Delete the latest item.
2. Once the latest item disappears, scroll up.

Details
bug2.mp4

The hover style flickers on items when scrolling with the mouse:

Details
bug3.mp4

The highlighted item position isn't reliable when opening the chat:

Details
bug4.mp4

Similarly, on web, the highlighted item is out of the viewport when it's a PDF preview:

Details
bug71.mp4

The loading state appears after sending a link message:

Details
bug8.mp4

The keyboard appears briefly:

Details
bug5.mp4

The keyboard doesn't appear when editing a long comment:

Details
bug6.mp4

On Android, the highlighted item is out of the viewport if there is a long comment above it:

Details
bug7.mp4

Unable to test due to a new bug:

The app automatically navigates back to the Home screen when "Reply in thread".

Details
bug2.mp4

Android: The highlighted item scrolls down and then back up:

bug1.mp4

Android: Scrolling slightly right after the loading state disappears causes the list to jump:

bug3.mp4

Web: The "Submit" badge needs to be clicked multiple times (sometimes 3–4 times) to scroll to the highlighted item.

Sometimes, the top of the highlighted item or the bottom of the last item in the list is obscured.

bug4.mp4

Remaining ⚠️

N/A


New bug ❗

Bug: Automatically scroll to the highlighted item when opening the PDF viewer:

Details
bug1.mp4

Bug: In a DM chat, the initial viewport isn't scrolled to the bottom when there's a new message, especially when the chat contains an IOU.

Details
bug2.mp4

Web: The chat in a thread isn't inverted.

Details
bug3.mp4

@dmkt9

dmkt9 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

I've now addressed all of the remaining issues from @dmkt9. Some of them i could not reproduce. @dmkt9 please make sure to test on a different emulator and/or a physical device.

After these issues we should be good to go.

@chrispader Thanks! All previously reported bugs have been resolved when testing on a physical device.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants