Skip to content

Coin selection on Withdrawal Requests, with UTXO selection strategy as parameter #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
imclvr wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Coin selection on Withdrawal Requests, with UTXO selection strategy as parameter #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d41ed23
Change proto specs to add coin selection strategy on wd requests
imclvr Sep 18, 2026
7c2ab1d
Integrate new coin selection strategy on wd requests
imclvr Sep 18, 2026
40f60e1
Deroute withdrawal request by coin selection strategy
imclvr Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Data/Models/WalletWithdrawalRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,11 @@
/// </summary>
public decimal? CustomFeeRate { get; set; }

/// <summary>
/// Coin selection strategy requested for this withdrawal. Null means the requestor did not pick one.
/// </summary>
public CoinSelectionStrategy? CoinSelectionStrategy { get; set; }

/// <summary>
/// Check that the number of signatures (not finalised psbt nor internal wallet psbt or template psbt are gathered and increases by one to count on the internal wallet signature
/// </summary>
Expand Down Expand Up @@ -211,7 +216,7 @@
public ApplicationUser UserRequestor { get; set; }
public int WalletId { get; set; }

public Wallet Wallet { get; set; }

Check warning on line 219 in src/Data/Models/WalletWithdrawalRequest.cs

View workflow job for this annotation

GitHub Actions / unit-test 

Nullability of reference types in type of parameter 'value' of 'void WalletWithdrawalRequest.Wallet.set' doesn't match implicitly implemented member 'void IBitcoinRequest.Wallet.set' (possibly because of nullability attributes).

public int? BumpingWalletWithdrawalRequestId { get; set; }

Expand Down
Loading
Loading