Repository navigation
fix(shell): stop sourced shell files from enabling errexit - #14
Merged
Merged
Conversation
The LS_COLORS, fzf and bat snippets started with set -euo pipefail; .zshrc sources them, which turned errexit/nounset on in the interactive shell so the first failing command closed the terminal.
An interactive .zshrc with set -euo pipefail closes the terminal on the first failing command and breaks plugins. Resolve the theme mode from the persisted live record before an inherited value, matching fish.
Completes c9cf723: the fzf variants were left out of that commit.
…tive shells dreamcoder-icons.sh is sourced by .zshrc and .bashrc; its set -euo pipefail closed the terminal on the first failing command.
This was referenced Sep 29, 2026
Dreamcoder08
force-pushed
the
pr/04-shell-safety
branch
from
September 29, 2026 18:47
1f69992 to
c9bc0bc
Compare
Dreamcoder08
force-pushed
the
pr/03-theme-mode-and-listener
branch
from
September 29, 2026 18:47
efd035b to
12256a6
Compare
Owner
Author
|
Verified independently at this slice tip (stacked PRs do not run CI until retargeted to |
Dreamcoder08
changed the base branch from
pr/03-theme-mode-and-listener
to
main
September 29, 2026 20:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Snippets sourced by
.zshrc/.bashrcstarted withset -euo pipefail, so the first failing command closed an interactive terminal.Changes
.zshrcdrops errexit/nounset and resolves the mode like fishdreamcoder-icons.shno longer enables errexit; a bats test sources every shell lib and asserts no option changedVerification
tests/test_sourced_snippets_shell_options.pyandtests/shell/test_sourced_shell_lib.bats(RED before, GREEN after); zsh survivesfalseafter startup.Chain Context
main)pr/03-theme-mode-and-listenerpr/03-theme-mode-and-listenerChain Overview
Scope
Autonomy