Repository navigation
fix(theme): keep the live mode and Dreamcoder colours stable across mode switches - #13
Merged
Merged
Conversation
restart_waybar left the new bar holding the caller's stdout, so theme apply (captured by Python or systemd) never returned.
ML4W upgrades reset btop.conf color_theme to matugen; nothing restored it.
theme_mode() only read DREAMCODER_THEME_MODE and defaulted to dark, so a bare dreamcoder sync (hooks, listeners, shells without the export) rendered Dreamcoder Dark over a system running Light. Fall back to ~/.cache/dreamcoder/cursor-cli.env, the record every mode switch writes, before the dark default.
05-dreamcoder-theme.fish trusted an inherited DREAMCODER_THEME_MODE (or assumed dark), so panes from a long-lived parent opened with dark LS_COLORS/EZA_COLORS over the Light terminal until the first prompt.
or rendered text on the warning swatch (2.09:1 light, 1.34:1 dark) and st used surface1 (4.31:1 light). Invert or onto the base bg and move st to surface0; a test now gates every LS_COLORS entry at 4.5:1 in Light and Dark.
…matugen ML4W 2.16's gtk-theme-switcher listener re-runs Matugen over the wallpaper on every gtk settings.ini change, including Dreamcoder's own mode switch, and overwrites Dreamcoder colour files before reloading Quickshell, Waybar, GTK and swaync. apply-ml4w-hooks.sh now inserts a marked block after each Matugen call that runs dreamcoder sync synchronously in the branch's mode (repo writes off, logged, bounded), and restarts the listener through listeners.sh when the file changes. Records T6 evidence and T8 in the feature document.
This was referenced Sep 29, 2026
Dreamcoder08
force-pushed
the
pr/02-stow-herdr-0.9.1
branch
from
September 29, 2026 18:47
f465802 to
b1e43ec
Compare
Dreamcoder08
force-pushed
the
pr/03-theme-mode-and-listener
branch
from
September 29, 2026 18:47
efd035b to
12256a6
Compare
Owner
Author
|
Verified independently at this slice tip (stacked PRs do not run CI until retargeted to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A bare
dreamcoder syncrendered Dark over a Light system, ML4W's GTK listener re-ran Matugen over Dreamcoder colours on every switch, and a few apply steps hung or were silently undone.Changes
theme_mode()falls back to the persisted live mode before defaulting to dark; fish starts in that modegtk-theme-switcher.shthat re-applies Dreamcoder colours right after each Matugen runrestart_waybardetaches the relaunched bar from the caller's streams (theme apply no longer hangs)color_themere-selected on every applylscolours for broken links and sticky dirs lifted to WCAG AA, with a 4.5:1 gate testVerification
New tests for each behaviour (mode resolution, listener fixture copied from ML4W 2.16, waybar detach, contrast gate); full suites green; a real dark to light toggle on a live machine leaves Starship, Hyprland and Waybar in Light.
Chain Context
main)pr/02-stow-herdr-0.9.1pr/02-stow-herdr-0.9.1Chain Overview
Scope
Autonomy