Repository navigation
Test: Make the Windows resize probe tell late frames from prompt ones, per Windows build - #354
Merged
Merged
Conversation
…ut DirectComposition The criterion said WM_SIZE returns after ResizeBuffers, the Skia draw, Present and a DirectComposition Commit. The window has no DirectComposition: during a size change it hides the GPU child, draws the frame with Skia's raster backend into a DIB and copies it into the top-level window's redirection surface with BitBlt before WM_SIZE returns, and with DXC_RASTER_RESIZE=0 it presents on the GPU and waits with DwmFlush. The measure of the criterion (no frame at another size) is unchanged. Refs #353
…mes from prompt ones On CI hand-check passes with resize frames on the CPU and on the GPU alike, so the probe has never shown it can tell a late frame from a prompt one, and Windows 11 26H2 may hold a window's new size back until its content is ready, which would hide lateness on its own. - resize-control.c: a negative control built like the GPU resize path (redirected top level, child with a copy-model swapchain, refit, draw, Present, DwmFlush inside WM_SIZE) that presents every new size DXC_RESIZE_PRESENT_DELAY_MS (50) late during a drag. It draws a ruler, so a stretched or misplaced picture moves. - resize-probe.c: the Windows version with its UBR as the first line (resize-os-version.h, shared with the control); a stale check (the content's left zone must stay where it was at rest; FR-19.8 criterion 4 counts a stretched or old frame as a failure); the lag of the window's edge behind the cursor per frame and per drag, in px and ms; the window is put on the primary monitor's work area by the probe itself when it is not there (--place-after, default 20 s), at whatever size it settles. - run-probe-v2.ps1: drags the control at each rate too, writes the OS line at the top of each application log, and writes summary.md, where a renderer's result is INCONCLUSIVE (no discrimination) at a rate where the control passes. - The probe workflow runs on windows-2022 (20348) and windows-2025 (26100), checks the control was late, and puts each runner's table in the job summary. Refs #353
…he backdrop On windows-2025 the console window the control opened sat beside it, above the probe's backdrop, and the probe stopped with "the backdrop does not show beside the window" for five of six control drags. Refs #353
This was referenced Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #353
The Windows resize probe now shows, per Windows build, whether it can tell a late frame from a prompt one, and the CI matrix shows that it can on both runner builds.
What changed
.github/scripts/resize-control.c(new): the negative control. Built like the renderer's GPU resize path (top-level window with its redirection surface and no brush, child window with a copy-model swapchain: SEQUENTIAL, 1 buffer, STRETCH; refit, draw, Present, fit the child, DwmFlush, all inside WM_SIZE), except that during a drag it sleepsDXC_RESIZE_PRESENT_DELAY_MS(50 by default) before drawing each new size. It draws a ruler (a dark line every 24 px) so a stretched or misplaced picture is visible. Linked as a GUI program so no console window covers the backdrop..github/scripts/resize-os-version.h(new): one line with the Windows version fromRtlGetVersionplusUBR,DisplayVersion,ProductName,InstallationTypefrom the registry..github/scripts/resize-probe.c:resize-probe: os windows 10.0.BUILD.UBR (...);lag_px(edge vs cursor at present time) andlag_ms(how long ago the cursor was where the edge is), and per draglag ... median / p95 / max;--place-afterseconds (20), or at once with--place, up to three times (a move between monitors of different scale changes the size), and takes whatever size it settles at (the larger minimum at 200%)..github/scripts/run-probe-v2.ps1: drags the control at each rate as well, writes the OS line at the top of each application log (.logand.log.err), and writessummary.md. A renderer's result at a mouse rate where the control PASSes readsINCONCLUSIVE (no discrimination); where the control did not run,INCONCLUSIVE (the control did not run)..github/workflows/test-windows-resize-probe.yml: matrixwindows-2022andwindows-2025; builds the control; the job passes when every drag ran, the Windows version is logged, hand-check took the asked path and every control step was at least 45 ms late. Verdicts are reported, not gated (WARP, Basic Render Driver).Committhe window does not have; it now describes the CPU path (hide the GPU child, Skia raster into a DIB, BitBlt into the redirection surface before WM_SIZE returns) and the GPU path withDXC_RASTER_RESIZE=0(ResizeBuffers, draw, Present, DwmFlush). The measure is unchanged.CI matrix results
Run https://github.com/DarkPyonix/compose-rust/actions/runs/40280843111 (head f473b77). hand-check is the Kotlin/Native build from run 38807049709 (pinned in the workflow, as before). Each cell: probe verdict, frames with black inside the window, stale frames, median lag in ms. Full tables with holes, torn and px lag are in each job summary.
What it shows:
DXC_RASTER_RESIZE=0): PASS in 11 of 12; on 26100 at 100% and 8 ms one frame was black and stale. The earlier run (40280134702, control broken on 2025 by its console window) had the same kind of single failure on 26100 at 200% and 1 ms (2 frames). None on 20348. Lag median 30 to 59 ms, about twice the CPU path's.소유자 실행 안내 (26H2 기기)
목적: 26H2(빌드 26300)에서 Windows가 늦은 프레임을 스스로 가리는지(대조군이 PASS하는지)와, 그 환경에서 CPU 경로와 GPU 경로의 결과와 지연을 확인합니다.
resize-probe-kit-windows를 내려받아 새 폴더(예:C:\probe-kit)에 풉니다. 명령줄로는gh run download 40280843111 -R DarkPyonix/compose-rust -n resize-probe-kit-windows -D C:\probe-kit입니다. 키트는 2026-11-25에 만료됩니다.run-probe-v2.cmd를 두 번 누릅니다. PowerShell에서는powershell -NoProfile -ExecutionPolicy Bypass -File C:\probe-kit\run-probe-v2.ps1입니다. 서명 없는 실행 파일이라 SmartScreen이 막으면 "추가 정보", "실행"을 누릅니다. hand-check(CPU 경로, GPU 경로)와 대조군 창을 마우스 속도 세 가지로 모두 9번 끕니다. 약 5분 동안 마우스를 만지지 않습니다. "Done"이 나오면 Enter로 닫습니다.probe-logs.zip하나입니다(안에summary.md표와 모든 로그가 있습니다). 끝날 때 콘솔에 나온 표의 스크린숏도 있으면 좋습니다.probe-logs.zip을 보냅니다. CI 러너는 Server와 WARP라서 "26H2 이전의 실제 기기에서 CPU 경로가 필요한가"는 그 비교로 답이 납니다.결과 읽는 법:
control late줄이 FAIL이면 그 기기에서 프로브가 늦은 프레임을 봅니다. 그때 hand-check의 PASS와 FAIL은 그대로 유효합니다.control late가 PASS이면 Windows가 늦은 프레임을 가리는 것이고, hand-check 줄은INCONCLUSIVE (no discrimination)로 나옵니다. 그 경우 차이는lag ms열(창 가장자리가 마우스를 얼마나 늦게 따라오는지)에만 남습니다.