Repository navigation
Fix: Keep Button and Chip labels on one line - #342
Merged
Merged
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #328
Button and Chip drew their label with BasicText defaults (softWrap true, no line limit). A parent that squeezes the control measures it at the label's min intrinsic width, which for Hangul is one syllable, so '보내' broke into '보' over '내'. The label is now maxLines 1, softWrap false (so min intrinsic width equals the single-line width) and ellipsis. Button still honours an explicit max_lines/overflow from the Host (both already accepted on Button); Chip takes no new property.
Adds SingleLineLabelTest (squeezed label height and width equal the roomy ones, every design system). Not compiled locally: the repo rule keeps builds to CI. Android Kotlin copy re-staged with scripts/stage-android-kotlin.sh.