Skip to content

Fix: Keep Button and Chip labels on one line - #342

Merged
b-re-w merged 4 commits into
developfrom
feat/label-single-line
Oct 26, 2026
Merged

b-re-w merged 4 commits into
developfrom
feat/label-single-line

Conversation

@b-re-w

@b-re-w b-re-w commented Oct 26, 2026

Copy link
Copy Markdown
Member

Closes #328

Button and Chip drew their label with BasicText defaults (softWrap true, no line limit). A parent that squeezes the control measures it at the label's min intrinsic width, which for Hangul is one syllable, so '보내' broke into '보' over '내'. The label is now maxLines 1, softWrap false (so min intrinsic width equals the single-line width) and ellipsis. Button still honours an explicit max_lines/overflow from the Host (both already accepted on Button); Chip takes no new property.

Adds SingleLineLabelTest (squeezed label height and width equal the roomy ones, every design system). Not compiled locally: the repo rule keeps builds to CI. Android Kotlin copy re-staged with scripts/stage-android-kotlin.sh.

@b-re-w b-re-w added the run-heavy-ci Run the heavy CI workflows on this pull request's head label Oct 26, 2026
@b-re-w

b-re-w commented Oct 26, 2026

Copy link
Copy Markdown
Member Author

인계 메모 (pF 세션 종료, 2026-10-26). 작업 브랜치는 모두 커밋, 푸시되어 있다. 머지 규칙: 이 PR이 고친다고 하는 것을 증명하는 체크가 현재 헤드에서 초록일 때만 머지한다.

상태: CI 대기 중. 폭 단언은 뺐고 SingleLineLabelTest는 한 줄 여부만 검사한다. v0.0.4 차단 항목.
다음: jvm 잡에서 SingleLineLabelTest 통과와 heavy gate 초록을 확인하고 머지, #328 닫기. 이어서 0.0.4 버전 올림(#340 참고).

@b-re-w
b-re-w merged commit 1a8debb into develop Oct 26, 2026
35 checks passed
@b-re-w
b-re-w deleted the feat/label-single-line branch November 12, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-heavy-ci Run the heavy CI workflows on this pull request's head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant