Repository navigation
Feat: Expose max_lines and overflow on Button - #141
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #140
Adds
max_linesandoverflowto the rsx Button (the renderer already accepts both on Button). Text already exposesmax_lines,overflowandsoft_wrap; Chip takes none (the renderer fixes its label to one line, compose-rust#342). rsx_surface now covers both Button props. Not compiled locally (CI builds). The "left out, one line" default needs the compose-rust fix (DarkPyonix/compose-rust#342) in the pinned renderer.