Repository navigation
Chore: Move the Compose fork pin to 1.11.1-ext.2 - #277
Merged
Merged
Conversation
REVISION, WINDOW_REVISION and MINGW_REVISION all move to c7caf51523e8 (tag v1.11.1-ext.2, the merge of the fork's bump-ext-2). COMPOSE_AS and MATERIAL3_AS become 1.11.1-ext.2 (the fork now versions material3 with the rest), the window modules go from 0.1.0 to 1.11.1-ext.2, compose-fork.changes and compose-fork-mingw.changes are regenerated from the new commit, and the tests and docs that name the versions follow.
…low AccessibleElement's move native/macos depends on scene now, so publish-window.sh keeps scene's jvm and macosArm64 platforms on a Mac that has the fork's Compose for macosArm64 (jvm alone elsewhere). The test fixture gains the scene module the script edits. AppKitWindow imports AccessibleElement from org.thisisthepy.compose.window, where it moved.
…neSemantics The fork's X11 windows (GraalVM and Kotlin/Native) join the AT-SPI bus and serve a reader themselves, from the AccessibleElement list given to setAccessibility, and report a reader's presses through WindowListener.onAccessibilityAction. AtspiSemanticsSource, X11Accessibility and the renderer-side AtspiBridge are gone. ReaderSemantics reads the scene with the fork's SceneSemantics, pushes the list through AccessibilityCache and carries a reader's request back to the control by id, in both renderers. The renderer modules depend on the scene module for it. The shell tests that read the fork's C and Kotlin follow the new layout: the macOS reader record is dxc_ax_element in appkit_accessibility.h, and the X11 C record is no longer written from Kotlin.
The fork's build-skiko-awt.sh publishes org.thisisthepy.compose.skiko:skiko-awt as 1.11.1-ext.2. SKIKO_AWT_AS, the desktop module, the artifact check, the native build scripts, workflow cache paths and shell tests follow it.
…thisisthepy/compose
The previous change left broken YAML in both workflows (a stray path line, and the comment landed in the NIK cache step). Restore both steps and add a marker file under ~/.m2/repository/org so upload-artifact keeps org as the root and the download restores the org/thisisthepy/compose prefix.
…image class path The fork lists JetBrains' skiko-awt as a second capability of every variant of its own skiko-awt. Amper takes a variant only when its capabilities are exactly the module's own coordinate, so it found none and stopped with "Platform is not supported by the library" at the GraalVM Linux build. publish-skiko-awt.sh drops the extra capability from the published copy. The fork's Compose modules still ask for org.jetbrains.skiko:skiko, so the native build scripts now filter JetBrains' skiko-awt off the class path and the fork's is the only one the image takes. Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
…off the image class path" This reverts commit 3e26d02.
Member
Author
|
Handoff (2026-10-25): Branch: feat/fork-pin-ext2. State: open, pinned to fork 1.11.1-ext.2; fork build, GraalVM smoke, renderer test and static renderer checks are red and not yet triaged. Next: once fork PR #167 is merged in compose-multiplatform-core-extended, repin to its merge commit, rerun, and triage the failures. It carries the glue fixes. Blocked on: fork PR #167 merge. |
This was referenced Oct 25, 2026
b-re-w
added a commit
that referenced
this pull request
Oct 26, 2026
… native/macos, retire the old-build equivalence failure The fork lists JetBrains' skiko-awt as a second capability of its skiko-awt, which Amper cannot resolve; publish-skiko-awt.sh drops it and the native build scripts keep JetBrains' copy off the image class path (from #277). publish-window.sh publishes scene whenever native/macos is built, for the platforms whose Compose is present. The equivalence comparison with the old patched build no longer fails the job now that the pin is on the ext.2 line.
Member
Author
|
Superseded by #360 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the Compose fork pin to the commit released as 1.11.1-ext.2 (tag
v1.11.1-ext.2,c7caf51523e8), which is on Maven Central.Coordinates moved
renderer/scripts/build-compose.sh:REVISION,WINDOW_REVISION,MINGW_REVISIONall toc7caf51523e8aa5f81563fcc7311398455ecacef;COMPOSE_ASandMATERIAL3_ASto1.11.1-ext.2(the fork now versions material3 with the rest; the upstream material3 version inMATERIAL3_PUBLISHED_ASis unchanged).1.11.1-ext.1to1.11.1-ext.2and1.11.0-alpha07-ext.1to1.11.1-ext.2inrenderer/macos,renderer/desktopandrenderer/linuxmodule.yaml.org.thisisthepy.compose.window:*from0.1.0to1.11.1-ext.2inrenderer/macos,desktop,linux(includingnative-linux-linuxx64and-linuxarm64) andwindowsmodule.yaml,publish-window.shtext, andscripts/tests/renderer/window-modules-no-awt.test.sh.compose-fork.changesandcompose-fork-mingw.changesregenerated from the new commit (472 paths each; all three pins are now the same commit).1.11.1-ext.1(guide troubleshooting pages,test-compose-from-fork.yml, shell tests).Glue changes
publish-window.sh: scene is built forjvmplusmacosArm64on a Mac with the fork's macosArm64 Compose, becausenative/macosnow depends on scene (it was forced tojvmonly).AppKitWindow.kt:AccessibleElementmoved from...window.graalvm.macosto...window.renderer/desktop/src/X11Window.ktand Kotlin/Nativerenderer/linux/src/LinuxWindow.kt,LinuxRenderer.kt): the fork's X11 windows now join the AT-SPI bus themselves (AtspiWindow) and publish theAccessibleElementlist fromsetAccessibility;AtspiSemanticsSource,X11Accessibilityand the renderer-sideAtspiBridgeuse are gone. NewReaderSemanticsreads the scene with the fork'sSceneSemantics, pushes throughAccessibilityCache, and carries a reader's press, focus or value request back to the control throughWindowListener.onAccessibilityAction.SemanticsFanOutis removed.renderer/desktopandrenderer/linuxdepend on the fork's scene module for it.appkit-window-layout(record isdxc_ax_elementinappkit_accessibility.h, Kotlin constants inAccessibilityRecords.kt),desktop-c-symbols,x11-window-layout,x11-window-frames,linux-input-access;publish-window-windows-toolsgets the scene module in its fixture.Verified on macOS
build-compose.sh --target desktop(9m05s) and--target macosArm64(4m44s),renderer/desktop/scripts/build-macos.sh(7m40s, includespublish-window.sh),./kotlin test -m desktop(570 of 571; the one failure is the timing-sensitivenfr9_measure_sidebar_costs_at_most_ten_percent_over_text_measurer; three context menu tests fail only under a Korean JVM locale and pass with-Duser.language=en),cargo test -p compose-rust --no-default-features --no-fail-fast, and everyscripts/tests/*.test.shexcept the ones that need a native-image build.Needs CI
Linux (Kotlin/Native and GraalVM X11 window, AT-SPI against a real registry), Windows, and the native-image tests (
image-has-no-awt,accessibility-runtime,linux-*) were not built here.