Repository navigation
Conversation
Member
Author
|
Closed in favour of a backport: the wheel fix is cherry-picked onto the current WINDOW_REVISION 57b4a0e as thisisthepy/compose-multiplatform-core-extended branch feat/windows-window-backport-57b4a0e (a1bcec5). One later PR will pin that branch after the Windows caption button fix joins it. #336 stays open for that PR; the regression script from this branch can be carried over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #336
The Windows mouse wheel scrolled in reverse on both Windows paths (GraalVM, which the samples ship today, and the Kotlin/Native windows-static path), because both compile the fork's
extended/window/windows-shared/c/win32_window.c, whoseWM_MOUSEWHEELcase (line 2117-2119 at the old pin) passed the Win32 delta through asscrollDelta.ywithout negating it.c/win32_wheel.hand an MSVC test.WINDOW_REVISIONmoves to that PR's commitd5c5408, one commit past the ext.2 window pin of Chore: Move the Compose fork pin to 1.11.1-ext.2 #277. Once Win32 live resize: present the new size before the window rect changes #170 merges, the pin should be moved to its merge commit (same tree for extended/window).scripts/tests/win32-wheel-direction.test.shcompiles the pinned header (cc on Linux CI, cl on Windows) and checks +120 vertical gives -lines, +120 horizontal gives +lines, +30 gives a quarter notch, and that the window procedure uses the header.Stacked on #277 (
feat/fork-pin-ext2), because moving the window pin past c7caf51 needs that PR's adaptations; retarget todevelopafter #277 merges.Not compiled locally (no local builds); CI builds.