Skip to content

Fix: Move the window pin to the fork's Win32 wheel direction fix - #337

Closed
b-re-w wants to merge 1 commit into
feat/fork-pin-ext2from
feat/win32-wheel-direction
Closed

b-re-w wants to merge 1 commit into
feat/fork-pin-ext2from
feat/win32-wheel-direction

Conversation

@b-re-w

@b-re-w b-re-w commented Oct 25, 2026

Copy link
Copy Markdown
Member

Closes #336

The Windows mouse wheel scrolled in reverse on both Windows paths (GraalVM, which the samples ship today, and the Kotlin/Native windows-static path), because both compile the fork's extended/window/windows-shared/c/win32_window.c, whose WM_MOUSEWHEEL case (line 2117-2119 at the old pin) passed the Win32 delta through as scrollDelta.y without negating it.

Stacked on #277 (feat/fork-pin-ext2), because moving the window pin past c7caf51 needs that PR's adaptations; retarget to develop after #277 merges.

Not compiled locally (no local builds); CI builds.

@b-re-w b-re-w added the run-heavy-ci Run the heavy CI workflows on this pull request's head label Oct 25, 2026
@b-re-w

b-re-w commented Oct 25, 2026

Copy link
Copy Markdown
Member Author

Closed in favour of a backport: the wheel fix is cherry-picked onto the current WINDOW_REVISION 57b4a0e as thisisthepy/compose-multiplatform-core-extended branch feat/windows-window-backport-57b4a0e (a1bcec5). One later PR will pin that branch after the Windows caption button fix joins it. #336 stays open for that PR; the regression script from this branch can be carried over.

@b-re-w b-re-w closed this Oct 25, 2026
@b-re-w
b-re-w deleted the feat/win32-wheel-direction branch November 12, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-heavy-ci Run the heavy CI workflows on this pull request's head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant