Skip to content

fix: release temporary factory host application references in VST3 #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rmt wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: release temporary factory host application references in VST3 #548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions distrho/src/DistrhoPluginVST3.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4800,6 +4800,8 @@ struct dpf_factory : v3_plugin_factory_cpp {
{
dpf_component** const componentptr = new dpf_component*;
*componentptr = new dpf_component(hostApplication);
if (hostApplication != nullptr)
v3_cpp_obj_unref(hostApplication);
*instance = static_cast<void*>(componentptr);
return V3_OK;
}
Expand All @@ -4811,6 +4813,8 @@ struct dpf_factory : v3_plugin_factory_cpp {
{
dpf_edit_controller** const controllerptr = new dpf_edit_controller*;
*controllerptr = new dpf_edit_controller(hostApplication);
if (hostApplication != nullptr)
v3_cpp_obj_unref(hostApplication);
*instance = static_cast<void*>(controllerptr);
return V3_OK;
}
Expand Down