Repository navigation
Conversation
Contributor
|
Thanks for the PR, makes sense to me. But I dont think the comments there are necessary. When I wrote that part it was beginning of vst3 details and DPF, I didnt know querying something would automatically assign ++refcount internally. |
rmt
force-pushed
the
fix/vst3-factory-host-reference-leak
branch
from
October 6, 2026 19:50
fe83bad to
120e7e8
Compare
Contributor
|
thank you. I forgot but please rebase against develop instead of main. new commits always go to develop first before reaching main |
rmt
force-pushed
the
fix/vst3-factory-host-reference-leak
branch
from
October 6, 2026 21:16
120e7e8 to
e27fa13
Compare
Contributor
|
And change the target branch to develop, not main :) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #547