Skip to content

Simple Implementations of Freyja and Alcov models with unit tests - #25

Open
danerkestey wants to merge 4 commits into
mainfrom
12-implement-simple-versions-of-freyja-andor-alcov-for-comparison
Open

Simple Implementations of Freyja and Alcov models with unit tests#25
danerkestey wants to merge 4 commits into
mainfrom
12-implement-simple-versions-of-freyja-andor-alcov-for-comparison

Conversation

@danerkestey

Copy link
Copy Markdown
Collaborator

Implemented simple versions of Freyja and Alcov models with respective unit tests using example data. Freyja uses lasso regression and Alcov is a simple linear regression -- both without intercepts.

@danerkestey danerkestey linked an issue Mar 4, 2024 that may be closed by this pull request
@danerkestey

Copy link
Copy Markdown
Collaborator Author

Recreating with R instead of Python.

@DBecker7

Copy link
Copy Markdown

Great work!

To make this more user friendly, it would be nice to have either of the following changes:

  1. Modify the functions to have the same inputs and outputs as provoc_optim(), then implement a method = "freyja" and method = "alcov" argument to the main provoc function. This would mean all of the same plotting, printing, etc. functions will work with this output.
  2. Make the output objects of class provoc, with all of the attributes. Again, this means we can use all the same methods, rather than re-implementing a plotting function.

@danerkestey
danerkestey force-pushed the 12-implement-simple-versions-of-freyja-andor-alcov-for-comparison branch from 9e18235 to 110664b Compare March 26, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement simple versions of Freyja and/or Alcov for comparison

2 participants