Skip to content

[No ticket — safety-net 312883915] Stop reporting cancelled-request AbortErrors as network failures #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cru-self-healing-agent wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[No ticket — safety-net 312883915] Stop reporting cancelled-request AbortErrors as network failures #2012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/lib/apollo/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,15 @@ const makeClient = (apiToken: string) => {
}
});

if (networkError) {
// Requests are aborted when a component unmounts or a query is
// superseded (e.g. quick navigation, list virtualization, or a
// batched request sharing an in-flight fetch with one that was
// cancelled). That's expected SPA behavior, not an API failure, so
// don't alarm the user with a raw "The user aborted a request."
// snackbar or count it as a real network error.
const isAbortError = networkError?.name === 'AbortError';

if (networkError && !isAbortError) {
dispatch('mpdx-api-error');
snackNotifications.error(networkError.message);
reportNetworkError(networkError, operation);
Expand Down
Loading