[No ticket — safety-net 312883915] Stop reporting cancelled-request AbortErrors as network failures - #2012
Open
cru-self-healing-agent[bot] wants to merge 1 commit into
Open
Conversation
The global Apollo onError link in client.ts treated every networkError identically, including fetch AbortErrors raised whenever a request is cancelled by navigation, component unmount, or a superseded/batched query. That's normal SPA behavior, not an API failure, but it still showed the raw browser message "The user aborted a request." in an error snackbar and reported it to RUM as a network error via reportNetworkError/addDatadogError. Co-Authored-By: Claude <[email protected]>
cru-self-healing-agent
Bot
requested review from
a team and
kegrimes
and removed request for
a team
August 31, 2026 17:35
Contributor
Bundle sizes [mpdx-react]Compared against 424b0c2 No significant changes found |
kegrimes
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
/accountLists/?/tools/fix/commitmentInfo(30.8% vs an 18% threshold) and/accountLists/?/reports/expectedMonthlyTotal/?(34.6%). Reproducing the monitor's owna / (b + 20) * 100formula against RUM confirmed both genuinely crossed — every other route sat at ≤6.8%, in line with the monitor's stated normal range (~4.7–7%).@action.frustration.type+@action.target.nameshowed 100% of it waserror_click(a click immediately followed by a JS error) on the "YES" confirm button and "Amount" field (commitmentInfo), and on "Edit Partnership Info"/"SAVE" (expectedMonthlyTotal). Every single@type:errorRUM event on both routes in the breach window had the identical message:"The user aborted a request."— a standard fetchAbortError.src/lib/apollo/client.ts's global ApolloonErrorlink treats everynetworkError(includingAbortError, which fires whenever a request is cancelled by navigation, component unmount, or a batched request sharing an in-flight fetch with one that got cancelled — normal SPA behavior) the same as a genuine API failure: it shows the usersnackNotifications.error(networkError.message)(the raw, confusing "The user aborted a request." text) and reports it to RUM viareportNetworkError/addDatadogError. That's what turns an ordinary, harmless cancellation into a "did my click work?" moment that drives repeat clicking, and what makes Datadog tag those clicks aserror_click. There is noAbortControlleranywhere else in this app's own code, so every abort observed here is Apollo/browser-cancellation noise, not something the user or an API caused.onErrorlink, skip the dispatch/snackbar/RUM-report fornetworkError.name === 'AbortError'. Genuine network/GraphQL errors are unaffected.fix-commitmentinfo-cache-gc, from the self-healing agent, also based on this same deployed version and tagged to this same monitor) adds a missingcache.gc()call after evicting a Contact in FixCommitmentInfo. That's a legitimate cache-hygiene gap, but it doesn't match this alert's evidence (different error type entirely — no AbortError involved) and doesn't touchexpectedMonthlyTotalat all, so this PR is not a duplicate of it.Testing
/accountLists/[id]/tools/fix/commitmentInfo).src/lib/apollotest suite and confirm no regressions.Checklist:
/quality:agent-reviewcommand locally and fixed any relevant suggestions