fix(release): verify root consumers from packed tarball - #292
Draft
seonghobae wants to merge 11 commits into
Draft
fix(release): verify root consumers from packed tarball#292seonghobae wants to merge 11 commits into
seonghobae wants to merge 11 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #291.
Exact TDD lineage
This Draft started from protected
main@e8109ec2a17de8bd6594487aa12c8c8a93cb2c03and owns onlytests/package/verify-package.mjsplussrc/packedRootConsumerIsolation.test.ts.The first test-only head
1e6705ed39b18161cf874bffec5e0d3bd88710c9failed during test setup because the regression usedimport.meta.url; that attempt is rejected as product evidence. Corrected test-only head065346eb01a7ee4740ce4086c6cc15e8d91a7114produced qualifying hosted RED in CI31653280023, build job94302080690: exact checkout, immutable installation, typecheck, and the pre-existing suite completed before the dedicated contract failed exactly because the protected verifier usednpm pack --dry-runand repository self-reference instead of one extracted tarball and isolated consumer tree.The first implementation head
e9cf52a92ec14acd1f9330de04503fbd3d4f9dd3made a real tarball and extracted it beneath a temporarynode_modules, but CI31654244618failed at the explicit ESM resolution assertion after 144 test files / 828 tests, exact 100% owned-production coverage, builds, browser, and Office evidence had passed. RCA: because the temporary consumer was still nested beneath the repository package scope, Node package self-reference resolved the Inkspan package name back to the checkout. Security Scan31654244629and SAST31654244643were successful; the failed package assertion was retained as new evidence.Current narrow repair
Current exact head is
e0da9e3fa6a3f8dca13fa929532ba4dd6afa1ffaagainst live basemain@e8109ec2a17de8bd6594487aa12c8c8a93cb2c03.The verifier now:
npm pack --json --ignore-scripts --pack-destinationarchive;node_modules/@contextualwisdomlab/cwl-editortree;package.jsonso Node package self-reference cannot inherit the repository package scope;Exact-head proof
For unchanged head
e0da9e3fa6a3f8dca13fa929532ba4dd6afa1ffa:31655236773: success. Build job94308194295checked out the exact head, completed immutable setup/typecheck, passed 144 test files / 828 tests and exact 100% owned-production statement/branch/function/line coverage, built every library, verified the exact npm tarball with isolated ESM/CommonJS/strict-TypeScript consumers, passed the remaining package verifiers, and built the standalone demo.94308194250: Chromium, Firefox, and WebKit success.94308194318,94308194332,94308194273, and94308194282: Python 3.11–3.14 success with the applicable branch/docstring gates.31655236736: success.31655236761: success.Integration boundary
Keep Draft/unmerged while #118 owns exact
v0.6.0publication from unchanged protected main. This next-release release-evidence repair is not represented as protected-main behavior or shipped evidence.