feat(diagnostics): add accessible writing guidance UI - #266
Draft
seonghobae wants to merge 42 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
This Draft stacks on #257 (
feat/writing-diagnostics-controller) at exact live basec2f6df89cb193f6e3b9abcbf1fba078c79385784.Implemented scope
Task 5 of the revision-bound writing-diagnostics plan provides Inkspan's built-in accessible presentation layer for already-validated host diagnostics:
EditorFrameslot immediately before the editable surface;Task 6 still owns revision-rechecked document mutation and undo-safe replacement application.
Test-first lineage
31589364165, job94090517654, failed becauseWritingDiagnosticsPanel.tsxdid not exist.59c9ed37d46d86331f961dc4eefcfb8a7ee57594passed focused TDD workflow31593045037, job94102108792: 22 focused tests, exact component coverage, TypeScript, repository-wide 100% owned-production coverage, package verification, and demo build.Workflow RCA and current head
Integration cleanup removed the temporary
writing-diagnostics-ui-tdd.ymlworkflow at predecessordebc374a7d579566d19d6f30ecfe718e111989c4. That push exposed an inherited invalid.github/workflows/release.yml: run31623381362failed before GitHub created any job.The failure matches merged #253's exact root cause: the Office dependency command used a YAML plain scalar containing
--only-binary=:all:, and the registry-verification Node heredoc terminator was over-indented. Both defects caused GitHub to reject the tag-only workflow at parse time on ordinary branch pushes.Current exact head is
3535115bb720d23e2473fa39c26f4157a04dfac1. It carries #253's already-validated executable release-workflow blobe735c099da64e130e1a5f0be25519112bbf00d63, changing only those two syntax defects and preserving release gates.Fresh current-head check-runs: 0. Therefore no current-head CI, security, coverage, package, browser, accessibility, or review gate is represented as passing. Absent evidence is non-passing.
Authority boundary
Inkspan only renders, navigates, and reports actions for already-validated host diagnostics. It does not infer grammar, tone, spelling, clarity, pragmatics, technical correctness, or quality. It does not call a model, provider, network, database, persistence service, or host transport. Host strings remain plain React text and no keyword, regular-expression, phrase-list, language-name, sender-domain, recipient-count, nearest-text, or positional fallback exists.
Fresh review and integration boundary
mainremains frozen by release issue release: reconcile Office and npm versions before next stable registry publication #118.Protected
mainremains outside this next-release stack; no predecessor CI, status, workflow, or review evidence transfers after head or base movement.