feat(diagnostics): integrate revision-safe actions into CwlEditor - #280
Draft
seonghobae wants to merge 36 commits into
Draft
feat(diagnostics): integrate revision-safe actions into CwlEditor#280seonghobae wants to merge 36 commits into
seonghobae wants to merge 36 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack boundary
This Draft is stacked on the current #266 branch
feat/writing-diagnostics-ui@a77a1e9f1bb431034995c1f445ba085b1bce0110. Current exact head isa76919bdbcaf3896724854f75dc60c95264dbeda.It owns the standalone
CwlEditorintegration slice for already-verified host writing diagnostics: public props, revision-safe imperative actions, plain-text replacement application, local Ignore/Dismiss/Explain events, accessible focus continuity, read-only abstention, and warning-free test assurance. Inkspan still performs no grammar, tone, clarity, pragmatics, technical-quality, or actionability inference and calls no model, provider, network, database, or persistence service.Public behavior
CwlEditoraccepts host diagnostics and exposesfocusWritingDiagnostic,applyWritingDiagnostic,ignoreWritingDiagnostic,dismissWritingDiagnostic, andrequestWritingDiagnosticExplanationthrough its imperative handle. Apply recalculates the exact current strong revision, rechecks controller generation/editor identity/editability/document equality immediately before dispatch, inserts replacement strictly as ordinary text, participates in ordinary undo/redo, and invalidates the prior diagnostic generation. Conflicts abstain rather than forcing a replacement onto moved content.Action evidence is privacy-minimized and does not copy authored text, selected text, replacement text, explanations, cookies, secrets, model output, or recipient/thread content. With no host diagnostics, no guidance UI or semantic fallback exists.
Exact restack and RCA lineage
The earlier functional head
e3d385b98f7a4d7ab30ba2519291efff57a76e48is historical only. The lane was non-force restacked onto the live #266 head.cd06daa383c609a9bbc6c01e02b6152491a0f8b7, run31660357819, job94323709468: focused behavior passed, then TypeScript correctly rejected the dismissal-focus test harness because itsWritingDiagnosticsControllerdouble had not adopted the requiredapplyDiagnosticcapability. The production API was not weakened; the test double was repaired.70c79f059878e371815ebc5b1c288117a003049c, run31660506026, job94324150414: focused behavior, typecheck, complete production tests, exact 100% coverage, builds, package consumers, and demo reached success, but the fail-closed workflow rejected a Reactnot wrapped in actwarning from dismissal focus assurance.24239918c84991807c7483133b8124a0d58ec34c, run31660859610, job94325198488: wrapping the click alone was insufficient. Full logs showed the remaining warning originated when direct test focus invoked the diagnostic card's focus-state update outsideact.a76919bdbcaf3896724854f75dc60c95264dbedawraps both focus-triggered and click-triggered state transitions inact; no warning suppression or relaxed gate was introduced.Exact-head proof
For unchanged exact head
a76919bdbcaf3896724854f75dc60c95264dbeda:31661100767, job94325917730: success.persist-credentials: false.Any later head or base movement invalidates this proof.
Integration boundary
Keep Draft/unmerged while #266 remains the predecessor and release issue #118 owns the exact protected
0.6.0source candidate. This PR does not publish npm, create a tag or GitHub Release, bypass branch protection, or claim collaborative parity. #281 owns the Yjs collaboration slice.