feat(diagnostics): bind diagnostics to exact editor revisions - #257
Draft
seonghobae wants to merge 26 commits into
Draft
feat(diagnostics): bind diagnostics to exact editor revisions#257seonghobae wants to merge 26 commits into
seonghobae wants to merge 26 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #256 (
feat/writing-diagnostics-decorations) at exact live base56d3da78c7330636f635699eec302b5ab7d0c2ae.Product slice
Implements Task 4 of the committed writing-diagnostics plan: the revision-bound controller for host-supplied diagnostics. Inkspan validates hostile diagnostic input before reading editor state, captures one immutable ProseMirror document snapshot, derives the strong document revision from that exact snapshot, resolves every selector atomically against it, and installs structural decorations only for the unchanged verified generation.
The controller performs no semantic language judgment, model/provider call, network access, persistence, tenant/auth logic, or stale-text repair. Every document-changing transaction invalidates the active generation. Asynchronous digest and selector work is fenced by monotonic generation and editor identity. Host callback exceptions are contained, and action events contain no authored source, explanation, replacement, prompt, or model output.
Test-first and defect evidence
The implementation retains an observable RED → GREEN history:
3d7f51c81e4bd6308a89ebd2b912b394fc37068d: workflow31560671280, job94002103814, failed because the controller implementation did not exist.01673b4497a2e9b51c9d799e6a684bb3c9c40580; workflow31588082298, job94086455633, failed as expected because a destroyed editor remained inverifyingrather than publishingstale.31588737188, job94088522761, applied the bounded source correction, passed focused behavior, exact coverage, and TypeScript, committed4609f4be433581832ab0529cb8c7bc36ccad5bf0, and removed itself.Implemented behavior
Exact-head acceptance
Exact final head:
c2f6df89cb193f6e3b9abcbf1fba078c79385784.Workflow
31588901010, job94089036234, completed successfully on that exact head:useWritingDiagnosticsController.ts: 436/436 statements, 11/11 functions, 150/150 branches;No inline review thread is unresolved on the current PR snapshot.
Remaining gates
This PR intentionally remains Draft and stacked. Protected
mainremains frozen for the 0.6.0 release candidate while release issue #118 is open. The branch-specific TDD workflow is retained only as exact implementation evidence and must be removed before eventual integration. Current-head required checks, independent approval, security evidence, parent-stack integration, and release-only publication remain mandatory.This PR does not claim Task 5 diagnostic UI, Task 6 standalone/imperative application integration, Task 7 collaborative parity, a merged release, or an npm publication.