feat(diagnostics): add fail-closed editor decorations - #256
Draft
seonghobae wants to merge 19 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Stacked implementation lane for Task 3 of PR #248's writing-diagnostics plan. This Draft targets
feat/writing-diagnostics-projection; the current projection/contract/design heads are explicit dependencies.Current stack authority
feat/writing-diagnostics-projection@5e49f37278bbdfb2b074fcdb809f72400d96a926;93230d80895735f4f0b02a600296c19a2c3be56a;main@e8109ec2a17de8bd6594487aa12c8c8a93cb2c03under release: reconcile Office and npm versions before next stable registry publication #118.The previous body still named predecessor parent/head identities and historical
main@a430b1c…as current; those claims are superseded.Product boundary and TDD lineage
This lane renders only already-validated structural ranges. Decorations contain static Inkspan classes, visual priority, and an opaque diagnostic identifier; they do not carry source text, title, explanation, replacement, category text, model output, executable markup, or semantic ARIA authority.
Earlier RED→GREEN evidence established the decoration/invalidation contract, hostile metadata containment, and the semantic-neutral accessibility correction. The forged
ariaInvalid: 'spelling'regression failed before production repair; the production field/type/normalization/DOM attribute were then removed and the hostile fixture was retained as an out-of-contract runtime attack case.The plugin:
docChangedtransaction rather than remapping stale host/model output;Exact-current-head evidence
For unchanged exact head
93230d80895735f4f0b02a600296c19a2c3be56a, focused Writing Diagnostics Decorations TDD run31966903293completed successfully after inheriting current ADR 0028/0029 and projection authority.This focused success does not transfer to descendants and is not a substitute for the final repository-wide exact-head gates. Any later parent/head movement requires fresh evidence.
Integration boundary
This PR remains Draft and stacked. PRs #248, #249, and #254 are dependency roots that must converge first. Temporary branch-specific TDD workflow material must not survive protected integration. Final readiness requires current canonical CI/security/SAST/coverage/package/browser/accessibility/review evidence, zero valid unresolved findings/contradictions, qualifying independent approval under live governance, and release-order authorization after #118.