feat(diagnostics): resolve revision-scoped text selectors - #254
Draft
seonghobae wants to merge 28 commits into
Draft
feat(diagnostics): resolve revision-scoped text selectors#254seonghobae wants to merge 28 commits into
seonghobae wants to merge 28 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Stacked implementation lane for Task 2 of PR #248's writing-diagnostics plan. This Draft targets
feat/writing-diagnostics-contractso Task 1 and the corrected v1 architecture remain explicit parent dependencies.Test-first evidence
The inverse resolver followed an observable RED → GREEN sequence:
src/writingDiagnosticProjection.test.tswas committed before the production module;31556595959failed becausewritingDiagnosticProjection.tsdid not exist;31556897070: a block leaf was emitted asafter\uFFFCrather than ProseMirror'safter\n\uFFFC;text-position-selectorexports, declaration inputs, and packed-package ESM/CommonJS/strict-TypeScript consumers were added;9c1e9127ba3c40bf1c6fd336e238848e6c07fb2c;322c838d23de9ba574bcc549ad1e72cd2dafe2fe.Included behavior
textBetween(0, size, '\n', '\uFFFC')projection parity;Corrected architecture inheritance
ADR 0028 and the v1 implementation-plan errata are now present on this exact branch. They require every local/remote
docChangedtransaction to invalidate a complete diagnostic generation and prohibit semantic behavior or ARIA derivation from opaque host strings. The projection resolver remains deterministic structural infrastructure and does not itself preserve a diagnostic across document changes.Exact current-head evidence
feat/writing-diagnostics-contract@322c838d23de9ba574bcc549ad1e72cd2dafe2fe;1e16e7926f458ec706542fc1f5d8993480e570df;31590812070: success on this exact head;Remaining gates
The PR remains Draft despite the focused current-head success.