fix(security): rebuild tenant-scoped admin authority on current main - #455
Draft
seonghobae wants to merge 7 commits into
Draft
fix(security): rebuild tenant-scoped admin authority on current main#455seonghobae wants to merge 7 commits into
seonghobae wants to merge 7 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Reconstruct the critical administrative authorization boundary directly on current protected
main, preserving the corrected tenant-scoped semantics while removing the unrelated OpenAPI/license regressions that entered predecessor #440 after its later branch update.Exact reconstruction identity
eb0a32e87e7470469c8fa0f8c67d9583654bef57;da48e22c9a2095092f1f0def55bba46a2d79ed4d;ee6a2a9824682def83a787d2187cee6d7cda362a;Security contract
Every administrative list, delete, and retry endpoint requires
tenant:configure, preserves the authenticatedTenantContext, and calls only tenant-scoped service operations. Missing or malformed authority fails before service interaction. Missing and foreign jobs are concealed as404. Compatibility defaults filter before legacy mutation; durable adapters must replace them with storage predicates and generation-fenced transitions.Test-first lineage
The original RED review evidence on #440 proved unscoped global list/delete/retry behavior and authentication fixtures that bypassed the real authority boundary. Corrected head
ee6a2a9824682def83a787d2187cee6d7cda362asupplied the reviewed GREEN implementation and focused regressions. This PR reconstructs that bounded semantic directly on current protected main; predecessor checks and reviews do not transfer.Scope boundary
This does not implement OIDC/JWT federation, database row-level security, durable authorization persistence, cross-organization delegation, or a complete audit ledger. It establishes the fail-closed application boundary those adapters must preserve.
Merge gate
Keep Draft until exact-head CI, Security Scan, SAST Semgrep, fuzz, zero valid unresolved findings, and a qualifying independent non-author approval are present. Do not import or reintroduce predecessor #440's unrelated OpenAPI deletions.