fix(security): scope job ID lookup after current reservation stack - #451
Draft
seonghobae wants to merge 3 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Reconstruct stale stacked PR #361's unique tenant-scoped identifier lookup boundary on the exact current reservation parent #443, preserving immutable UUID ownership while removing global-read fallbacks.
Exact stack identity
d5a57a7f4e97467bb2fb163f37e4de5691d7ba31;87e41e97d557f0f711eda83ba3245bf62eff620a;ff6185f318be66fe706f1cf0e12a4063a8bd408b;Contract
Default repository and service tenant-ID lookups fail closed rather than invoking globally addressable reads. The in-memory adapter normalizes and applies tenant ownership at its storage boundary while rejecting absent tenant/job authority and concealing foreign jobs. The default application service delegates the tenant predicate to that repository boundary.
Scope boundary
This is a process-local adapter contract. It does not add durable row-level security, database persistence, distributed authorization, generation-fenced mutation, or identity-provider integration. The parallel admin-boundary work is now owned by clean current-main replacement #455; contaminated predecessor #440 is closed and none of its evidence transfers. #455 adds adjacent tenant-scoped list/delete/retry service operations, so the two deltas must be reconciled after their respective parent lines integrate.
Merge gate
Keep Draft while #443/#432 remain unmerged. Require this exact child head's emitted checks and zero valid unresolved findings. After ancestors and clean parallel #455 reach protected
main, rebuild or retarget the bounded delta onto the new exact protected base and regenerate all main-targeted CI, Security Scan, SAST, fuzz, current-head reviews, and qualifying independent approval. No evidence from #361, #440, or predecessor heads transfers.