fix(reliability): reserve conversion job identifiers after current analytics - #443
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Read-only child-head review request for @opencode-agent review |
Rate Limit Exceeded
|
Objective
Reconstruct stale stacked PR #345's unique immutable conversion-job identifier ownership delta on the exact current analytics parent #432, without importing stale #342 ancestry.
Exact stack identity
e0c02dc3305020ae1ad6900d0a04790aee7104d3;8dfab1a25d26090c04ed2ba15a88ef6987a58e6b;d5a57a7f4e97467bb2fb163f37e4de5691d7ba31;InMemoryConversionJobRepository.javaand its focused identifier-reservation regression;Contract
A conversion-job UUID remains reserved for the lifetime of the process-local repository, including after deletion. A distinct object cannot replace a live or previously deleted identifier; collision rejection occurs before untrusted candidate content-hash access; the exact live object remains an idempotent hit. Primary/secondary indexes and the reservation set mutate under one process-local synchronization boundary.
Scope boundary
This is an in-memory integrity/fencing primitive. It does not provide restart-durable reservations, transactional outbox semantics, worker lease generations, deletion receipts, cancellation, backpressure, or distributed fencing.
Merge gate
Keep Draft while #432 remains unmerged. Child CI/fuzz success is useful review evidence but not protected-main merge evidence. After #432 reaches protected
main, rebuild or retarget this two-file delta onto the new exact protected base and regenerate all main-targeted CI, Security Scan, SAST, fuzz, current-head reviews, and independent approval. No evidence from #345, #342, or predecessor heads transfers.