fix(roles): stop naming keyboard parts from mixed accompaniment - #883
fix(roles): stop naming keyboard parts from mixed accompaniment#883cursor[bot] wants to merge 34 commits into
Conversation
- 레지스터 중복 감지 이중 루프를 필터-루프로 개선하여 O(N^2) 성능 오버헤드 완화 - 대형 배열 오디오 처리에 의한 Unbounded Memory Consumption 완화 위해 사이즈 제한 적용 - trivy-fs 스캔에서 보고된 pdfjs-dist 취약점 패치 및 예외 처리
- 레지스터 중복 감지 이중 루프를 필터-루프로 개선하여 O(N^2) 성능 오버헤드 완화 - 대형 배열 오디오 처리에 의한 Unbounded Memory Consumption 완화 위해 최대 1억 샘플 사이즈 제한 적용 - 수많은 stem 인풋으로 인한 Denial of Service 방지를 위해 최대 stem 갯수 100개 제한 적용 - trivy-fs 스캔에서 보고된 pdfjs-dist 취약점 패치 및 예외 처리
- 레지스터 중복 감지 이중 루프를 필터-루프로 개선하여 O(N^2) 성능 오버헤드 완화 - 대형 배열 오디오 처리에 의한 Unbounded Memory Consumption 완화 위해 최대 1억 샘플 사이즈 제한 적용 - 수많은 stem 인풋으로 인한 Denial of Service 방지를 위해 최대 stem 갯수 100개 제한 적용 - trivy-fs 스캔에서 보고된 pdfjs-dist 취약점 패치 및 예외 처리
- 레지스터 중복 감지 이중 루프를 필터-루프로 개선하여 O(N^2) 성능 오버헤드 완화 - 대형 배열 오디오 처리에 의한 Unbounded Memory Consumption 완화 위해 최대 1억 샘플 사이즈 제한 적용 - 수많은 stem 인풋으로 인한 Denial of Service 방지를 위해 최대 stem 갯수 100개 제한 적용 - trivy-fs 스캔에서 보고된 pdfjs-dist 취약점 패치 및 예외 처리
- 레지스터 중복 감지 이중 루프를 필터-루프로 개선하여 O(N^2) 성능 오버헤드 완화 - 대형 배열 오디오 처리에 의한 Unbounded Memory Consumption 완화 위해 최대 10,000,000 샘플 사이즈 제한 적용 - 수많은 stem 인풋으로 인한 Denial of Service 방지를 위해 최대 stem 갯수 10개 제한 적용 - trivy-fs 스캔에서 보고된 pdfjs-dist 취약점 패치 및 예외 처리
Revert the latest branch-wide dependency, Trivy, Jules-note, and altered resource-limit drift. Preserve the previously reviewed two-file register-overlap optimization and its focused resource-guard regressions; coordinated dependency security remains owned by #783.
Drop the Bolt-head 10M-sample and 10-stem silent guards, the Trivy ignore, and the npm/PDF.js lock churn so this change stays an overlap optimization. Keep fail-closed invalid thresholds and the policy-owned admission regressions. Co-authored-by: Seongho Bae <[email protected]>
Stop fabricating keyboard and vocal clash copy. Slice admitted stems to each section, format honest accompaniment labels, and refresh rehearsal priority from measured occupancy. Co-authored-by: Seongho Bae <[email protected]>
Keep mixed accompaniment evidence off named keyboard and guitar roles in the RoleExtractor suite, and omit overlap warnings when section windows are missing or do not match the section list so a song-wide FFT cannot repeat on every card. Co-authored-by: Seongho Bae <[email protected]>
Keep htdemucs other from activating Keyboard Left/Right or Acoustic Guitar, and replace fabricated demo clash copy with the engine next-action wording on unambiguous bass and vocal roles. Co-authored-by: Seongho Bae <[email protected]>
There was a problem hiding this comment.
Review at 23678f39 vs develop
This is the presence + demo-honesty landing for the overlap lineage. Prefer it over draft #873 (9f1e166d). Do not merge #873 in parallel. Do not mix lock-in (#880) or Stem Lab (#884) onto this head.
Verified:
map_stems_to_rolesmaps onlyvocals→lead-vocalandbass→bass-guitar. Mixedothercannot mark Keyboard Left Hand, Keyboard Right Hand, or Acoustic Guitar active.test_map_stems_to_roles_other_does_not_name_accompaniment_roleslocks that contract.- Shared demo, browser-fallback, and Rust fixtures replace
Density warning/Melodic overlap/ named keyboard clash copy with the engine next-action sentence. Keyboard-hand and guitar demo warnings are empty. - SectionRoadmap asserts the honest bass sentence and rejects the fabricated identity strings.
- Doctoring cites Bregman (1990), Moore (2012), Foote (2000), and ISO 226:2023 and keeps overlap on
song -> section -> rolewindows.
No Critical findings on this head.
Residual, not a merge blocker for this slice: compute_handoffs tests still feed a synthetic keys-left activation. That path can no longer come from map_stems_to_roles. Keep it as a unit of the handoff helper, or drop the synthetic key so the test does not imply a live product path. A dedicated accompaniment role card still needs a later contract; do not rename other into keys or guitar to fill it.
This comment is not approval. Keep the draft until exact-head CI and a qualifying independent non-author last-push review exist.
Sent by Cursor Automation: Fix Issues


Closed as proven duplicate of canonical #873
Exact duplicate/supersession evidence was revalidated immediately before closure:
9f1e166da9acf043b7f4b8b6df84b5e1a2417706.23678f3931dd497dc3c21312544e5843da99a9d4is a direct fast-forward child of that head:compare(9f1e166d…, 23678f39…)reportsahead_by=1,behind_by=0.othercannot authorize named keyboard/guitar roles, and demo/browser/shared/Rust fixtures no longer fabricate those identities.cursor/bc-250fad94-8fb4-48fa-b3e0-959ae4494cb3-d696was fast-forwarded without force to this exact23678f39…commit and refetched successfully.No checks/reviews from this PR are transferred. #873 must regenerate exact-current-head repository and central evidence on
23678f39…; #783/#861/#781/#866 and independent approval remain separate gates.