test(roles): lock measured overlap priority refresh - #889
Closed
seonghobae wants to merge 35 commits into
Closed
Conversation
- 레지스터 중복 감지 이중 루프를 필터-루프로 개선하여 O(N^2) 성능 오버헤드 완화 - 대형 배열 오디오 처리에 의한 Unbounded Memory Consumption 완화 위해 사이즈 제한 적용 - trivy-fs 스캔에서 보고된 pdfjs-dist 취약점 패치 및 예외 처리
- 레지스터 중복 감지 이중 루프를 필터-루프로 개선하여 O(N^2) 성능 오버헤드 완화 - 대형 배열 오디오 처리에 의한 Unbounded Memory Consumption 완화 위해 최대 1억 샘플 사이즈 제한 적용 - 수많은 stem 인풋으로 인한 Denial of Service 방지를 위해 최대 stem 갯수 100개 제한 적용 - trivy-fs 스캔에서 보고된 pdfjs-dist 취약점 패치 및 예외 처리
- 레지스터 중복 감지 이중 루프를 필터-루프로 개선하여 O(N^2) 성능 오버헤드 완화 - 대형 배열 오디오 처리에 의한 Unbounded Memory Consumption 완화 위해 최대 1억 샘플 사이즈 제한 적용 - 수많은 stem 인풋으로 인한 Denial of Service 방지를 위해 최대 stem 갯수 100개 제한 적용 - trivy-fs 스캔에서 보고된 pdfjs-dist 취약점 패치 및 예외 처리
- 레지스터 중복 감지 이중 루프를 필터-루프로 개선하여 O(N^2) 성능 오버헤드 완화 - 대형 배열 오디오 처리에 의한 Unbounded Memory Consumption 완화 위해 최대 1억 샘플 사이즈 제한 적용 - 수많은 stem 인풋으로 인한 Denial of Service 방지를 위해 최대 stem 갯수 100개 제한 적용 - trivy-fs 스캔에서 보고된 pdfjs-dist 취약점 패치 및 예외 처리
- 레지스터 중복 감지 이중 루프를 필터-루프로 개선하여 O(N^2) 성능 오버헤드 완화 - 대형 배열 오디오 처리에 의한 Unbounded Memory Consumption 완화 위해 최대 10,000,000 샘플 사이즈 제한 적용 - 수많은 stem 인풋으로 인한 Denial of Service 방지를 위해 최대 stem 갯수 10개 제한 적용 - trivy-fs 스캔에서 보고된 pdfjs-dist 취약점 패치 및 예외 처리
Revert the latest branch-wide dependency, Trivy, Jules-note, and altered resource-limit drift. Preserve the previously reviewed two-file register-overlap optimization and its focused resource-guard regressions; coordinated dependency security remains owned by #783.
Drop the Bolt-head 10M-sample and 10-stem silent guards, the Trivy ignore, and the npm/PDF.js lock churn so this change stays an overlap optimization. Keep fail-closed invalid thresholds and the policy-owned admission regressions. Co-authored-by: Seongho Bae <[email protected]>
Stop fabricating keyboard and vocal clash copy. Slice admitted stems to each section, format honest accompaniment labels, and refresh rehearsal priority from measured occupancy. Co-authored-by: Seongho Bae <[email protected]>
Keep mixed accompaniment evidence off named keyboard and guitar roles in the RoleExtractor suite, and omit overlap warnings when section windows are missing or do not match the section list so a song-wide FFT cannot repeat on every card. Co-authored-by: Seongho Bae <[email protected]>
Keep htdemucs other from activating Keyboard Left/Right or Acoustic Guitar, and replace fabricated demo clash copy with the engine next-action wording on unambiguous bass and vocal roles. Co-authored-by: Seongho Bae <[email protected]>
Keep the 80 Hz verse / 1 kHz chorus fixture from dropping HIGH/MEDIUM priority when warnings attach or clear, and retire the leftover Melodic overlap phrase in the priority unit test. Co-authored-by: Seongho Bae <[email protected]>
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed as proven superseded by canonical #873
Exact evidence immediately before closure:
23678f3931dd497dc3c21312544e5843da99a9d4;7f45a293f8fb7a505d4cb24a3d6b290955720b47was its direct one-commit fast-forward descendant (ahead_by=1,behind_by=0, merge base exactly23678f39…);services/analysis-engine/tests/test_priority.pyandservices/analysis-engine/tests/test_roles.py: measured overlap now explicitly locks verse Basshigh, chorus Bassmediumafter the warning clears, and the priority fixture uses the current next-action warning sentence;cursor/bc-250fad94-8fb4-48fa-b3e0-959ae4494cb3-d696was fast-forwarded without force to exact7f45a293…;identicalwith zero changed files.Therefore this PR has no remaining unique semantic or test delta outside canonical #873. No checks, reviews, approval, or predecessor evidence transfer. #873 must regenerate/revalidate all required exact-current-head repository/central coverage, security/SBOM/supply-chain and review evidence on
7f45a293…; #783/#861/central prerequisites and independent approval remain separate gates.