Skip to content

feat(evidence): retain paragraph-span prototype as superseded evidence - #56

Closed
seonghobae wants to merge 5 commits into
maintenance/repair-base-b2a3f879from
agent/evidence-semantic-units
Closed

feat(evidence): retain paragraph-span prototype as superseded evidence#56
seonghobae wants to merge 5 commits into
maintenance/repair-base-b2a3f879from
agent/evidence-semantic-units

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Superseded by PR #83

This branch established useful exact-offset evidence, but its public semantic-unit contract equates units with blank-line paragraph splitting. That is not sufficient authority for mixed scripts, headings, lists, tables, code, captions, DOM structure, one oversized paragraph, exact final-payload token budgets, recursive recovery, hierarchy or context restoration.

PR #83 is the canonical design owner for the same TEPP bounded context. It preserves the useful exact-source-span direction while adding language-agnostic structure, immutable model profiles, rendered-payload accounting, lossless oversized-unit recovery, hierarchy, embedding_space_id, provider-neutral boundaries and APA 7 research traceability.

Preserve this branch and its regressions as historical implementation evidence. Port any unique useful tests into the post-#83 implementation plan rather than maintaining two competing semantic-unit contracts.

Closing this PR prevents ambiguous ownership and duplicate implementation lanes; it does not claim that PR #83 has already implemented the production capability.

Superseded by #83.

Blank-line units keep source positions for later meaning search.
Collapsing a multi-paragraph document into one bag-of-words unit
fails closed. No new migration.
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c67ec78-bf17-4a4c-ae04-7f26ccdd7207

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae changed the base branch from main to maintenance/repair-base-b2a3f879 August 15, 2026 10:12
@seonghobae
seonghobae marked this pull request as ready for review August 15, 2026 10:14

Copy link
Copy Markdown
Contributor Author

Superseded by #83.

This branch correctly preserves exact paragraph offsets, but it treats text.split("\n\n") as the semantic-unit product contract. That scope does not satisfy the now-explicit requirements for language-independent base correctness, final rendered-payload token counting, a versioned embedding-model profile, recursive handling of one oversized paragraph, typed headings/lists/tables/code/captions/DOM blocks, optional dense boundary evidence, leaf/section/document hierarchy, mixed-script robustness, or parent/neighbor context restoration.

PR #83 proposes ADR 0017, a PRD v0.5 delta, research traceability, a full design, and an atomic TDD implementation plan. It preserves paragraph boundaries as one source-structure signal rather than accepting them as semantic truth. Closing this draft avoids parallel, contradictory public APIs and duplicate Checks. No implementation or release claim is transferred automatically; #83 remains a proposed design pending exact-head checks and independent review.

@seonghobae seonghobae closed this Aug 15, 2026
@seonghobae seonghobae changed the title feat(evidence): split paragraphs into exact-span semantic units feat(evidence): retain paragraph-span prototype as superseded evidence Aug 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant