Skip to content

feat(validation): exact-head claim promotion gates - #57

Draft
seonghobae wants to merge 1 commit into
mainfrom
agent/validation-claim-promotion
Draft

feat(validation): exact-head claim promotion gates#57
seonghobae wants to merge 1 commit into
mainfrom
agent/validation-claim-promotion

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Summary

#37#56 remain review-blocked (no independent APPROVE). #45 marked ready again. Next no-0008 gap: ADR 0014 exact-head claim promotion in existing validation_core (no new crate; remaining STM/DSEM/morphology wait on #48/#49/#53).

  • Four authorities stay distinct: decision_accepted, implemented_main, scientifically_supported, released
  • Implementation/scientific/release bind to one exact protected-head SHA
  • Queued checks, predecessor-head results, skipped required tests, and LLM judgments fail closed
  • Scientific promotion uses computed RMSE and its standard error, not a hardcoded threshold

Test plan

  • RED: claim_promotion_contract failed with E0432/E0599
  • cargo test -p validation_core --offline
  • cargo clippy -p validation_core --all-targets --offline -- -D warnings
  • python3 scripts/validate_documentation.py and check_docstrings.py
  • line coverage 313/313
  • exact-head required Checks (do not treat queued evidence as passed)

Do not self-approve or merge. Prefer merge #37 then #45 when eligible. Do not allocate 0008.

Refuse implemented-main, scientific, and release promotions from queued,
predecessor, skipped, or LLM evidence. Scientific promotion uses computed
RMSE and its standard error rather than a hardcoded threshold.
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6a9f8d7a-ae41-4ec9-a983-1d2dde1aa6ec

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant