feat: open Calendar commitments onto Event Lineage (v2.14.0) - #261
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Cycle 2026-08-19T16:16 KST: v2.15 Customer master Event Lineage focus is stacked on this exact head as feat/customer-master-open-focus-event-lineage-v2150. Independent exact-head APPROVE still required here. Do not self-approve. |
d25f180 to
8ed5015
Compare
32993eb to
3990fc9
Compare
20d87bf to
196a709
Compare
916b787 to
fe849c0
Compare
196a709 to
eabf839
Compare
fe849c0 to
585055b
Compare
eabf839 to
d203328
Compare
585055b to
5e12caa
Compare
d203328 to
85db4e1
Compare
5e12caa to
5267614
Compare
85db4e1 to
4fc6e7c
Compare
5267614 to
9aac2b7
Compare
4fc6e7c to
31b0dea
Compare
9aac2b7 to
88c6ae5
Compare
31b0dea to
e854c93
Compare
88c6ae5 to
fc39af1
Compare
e854c93 to
7ef8d4e
Compare
fc39af1 to
736721f
Compare
Calendar names authorized commitments as current. Opening one focuses Event Lineage. Home-list opens do not.
Opening a post from Weekly VOC or Calendar (ADR 0093/0094) focuses the Event Lineage heading and merely names Keyman/evaluation as the next read. But KeymanPanel's landFirstRelated effect unconditionally auto-drilled into the first related node and, once that async chain resolved, yanked focus to the Ask panel -- even though no one asked for the Ask hand-off in that flow. That silent focus jump is exactly the behavior the report-member flow (ADR 0078) does want, so the fix threads a focusAskOnLand flag through PostDetailPopup -> KeymanPanel and only lets the drill claim focus for the report-member open. Confirmed pre-existing on this branch's own pristine tip (reproduced before merging anything else in), not introduced by any local change.
736721f to
b7ade01
Compare
7ef8d4e to
2ee8378
Compare
Summary
Stacked on #260. Opening a Calendar commitment focuses Event Lineage the same way Weekly VOC and report-member opens do.
Correctness repair
The first focus repair prevented the auto-drilled Keyman path from moving keyboard focus to Ask for Calendar and Weekly VOC. The same effect still called
scrollIntoView()unconditionally, so the viewport could jump to Ask even though Event Lineage correctly retained focus.A bounded one-shot RED→GREEN workflow adds a Calendar regression that waits until related evidence lands, confirms Event Lineage still owns focus, and rejects any scroll to
#post-ask. It then gates both focus and scrolling on the report-member-only hand-off, runs the focused and full frontend suites, lint, production build, and Storybook, and publishes only from the exact tested branch head. The workflow removes itself before publishing the production commit.No passing result is claimed while that exact-head workflow remains queued, running, or failed.
Merge safety
93 passedevidence as current-head evidence.