Skip to content

feat: open Calendar commitments onto Event Lineage (v2.14.0) - #261

Open
seonghobae wants to merge 3 commits into
feat/board-weekly-voc-open-event-lineage-v2130from
feat/calendar-open-focus-event-lineage-v2140
Open

feat: open Calendar commitments onto Event Lineage (v2.14.0)#261
seonghobae wants to merge 3 commits into
feat/board-weekly-voc-open-event-lineage-v2130from
feat/calendar-open-focus-event-lineage-v2140

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Stacked on #260. Opening a Calendar commitment focuses Event Lineage the same way Weekly VOC and report-member opens do.

  • Buyer Calendar names authorized commitments as current and asks the user to open one to read Event Lineage (ADR 0094).
  • That open focuses the popup Event Lineage heading and names Keyman and evaluation next.
  • A Board home-list open does not gain that focus or copy.
  • Advanced-review Calendar stays silent so lab status queries remain unique.
  • No TEPP theta or CalDAV event is invented.

Correctness repair

The first focus repair prevented the auto-drilled Keyman path from moving keyboard focus to Ask for Calendar and Weekly VOC. The same effect still called scrollIntoView() unconditionally, so the viewport could jump to Ask even though Event Lineage correctly retained focus.

A bounded one-shot RED→GREEN workflow adds a Calendar regression that waits until related evidence lands, confirms Event Lineage still owns focus, and rejects any scroll to #post-ask. It then gates both focus and scrolling on the report-member-only hand-off, runs the focused and full frontend suites, lint, production build, and Storybook, and publishes only from the exact tested branch head. The workflow removes itself before publishing the production commit.

No passing result is claimed while that exact-head workflow remains queued, running, or failed.

Merge safety

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: beb55bb3-a86e-4cd8-a55c-3583dc2ee190

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-19T16:08 KST: write-retry. Independent exact-head APPROVE still required. Do not self-approve. Issues #79 and #87 stay open.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-19T16:16 KST: v2.15 Customer master Event Lineage focus is stacked on this exact head as feat/customer-master-open-focus-event-lineage-v2150. Independent exact-head APPROVE still required here. Do not self-approve.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-08-19T16:31 KST. Stack continues #261#262#263 (v2.16 Ask Agent). Independent exact-head APPROVE still required. Do not self-approve. Issues #79 and #87 stay open.

@seonghobae
seonghobae force-pushed the feat/board-weekly-voc-open-event-lineage-v2130 branch from d25f180 to 8ed5015 Compare August 20, 2026 01:09
@seonghobae
seonghobae force-pushed the feat/calendar-open-focus-event-lineage-v2140 branch 2 times, most recently from 32993eb to 3990fc9 Compare August 20, 2026 01:15
@seonghobae
seonghobae marked this pull request as draft August 20, 2026 01:49
@seonghobae
seonghobae force-pushed the feat/board-weekly-voc-open-event-lineage-v2130 branch from 20d87bf to 196a709 Compare August 20, 2026 01:52
@seonghobae
seonghobae force-pushed the feat/calendar-open-focus-event-lineage-v2140 branch from 916b787 to fe849c0 Compare August 20, 2026 01:54
@seonghobae
seonghobae force-pushed the feat/board-weekly-voc-open-event-lineage-v2130 branch from 196a709 to eabf839 Compare August 20, 2026 02:00
@seonghobae
seonghobae force-pushed the feat/calendar-open-focus-event-lineage-v2140 branch from fe849c0 to 585055b Compare August 20, 2026 02:00
@seonghobae
seonghobae marked this pull request as ready for review August 20, 2026 02:02
@seonghobae
seonghobae force-pushed the feat/board-weekly-voc-open-event-lineage-v2130 branch from eabf839 to d203328 Compare August 20, 2026 02:04
@seonghobae
seonghobae force-pushed the feat/calendar-open-focus-event-lineage-v2140 branch from 585055b to 5e12caa Compare August 20, 2026 02:04
@seonghobae
seonghobae force-pushed the feat/board-weekly-voc-open-event-lineage-v2130 branch from d203328 to 85db4e1 Compare August 20, 2026 02:07
@seonghobae
seonghobae force-pushed the feat/calendar-open-focus-event-lineage-v2140 branch from 5e12caa to 5267614 Compare August 20, 2026 02:07
@seonghobae
seonghobae force-pushed the feat/board-weekly-voc-open-event-lineage-v2130 branch from 85db4e1 to 4fc6e7c Compare August 20, 2026 02:19
@seonghobae
seonghobae force-pushed the feat/calendar-open-focus-event-lineage-v2140 branch from 5267614 to 9aac2b7 Compare August 20, 2026 02:19
@seonghobae
seonghobae force-pushed the feat/board-weekly-voc-open-event-lineage-v2130 branch from 4fc6e7c to 31b0dea Compare August 20, 2026 02:27
@seonghobae
seonghobae force-pushed the feat/calendar-open-focus-event-lineage-v2140 branch from 9aac2b7 to 88c6ae5 Compare August 20, 2026 02:27
@seonghobae
seonghobae force-pushed the feat/board-weekly-voc-open-event-lineage-v2130 branch from 31b0dea to e854c93 Compare August 20, 2026 02:35
@seonghobae
seonghobae force-pushed the feat/calendar-open-focus-event-lineage-v2140 branch from 88c6ae5 to fc39af1 Compare August 20, 2026 02:35
@seonghobae
seonghobae force-pushed the feat/board-weekly-voc-open-event-lineage-v2130 branch from e854c93 to 7ef8d4e Compare August 20, 2026 02:40
@seonghobae
seonghobae force-pushed the feat/calendar-open-focus-event-lineage-v2140 branch from fc39af1 to 736721f Compare August 20, 2026 02:40
Calendar names authorized commitments as current. Opening one focuses
Event Lineage. Home-list opens do not.
Opening a post from Weekly VOC or Calendar (ADR 0093/0094) focuses the
Event Lineage heading and merely names Keyman/evaluation as the next
read. But KeymanPanel's landFirstRelated effect unconditionally
auto-drilled into the first related node and, once that async chain
resolved, yanked focus to the Ask panel -- even though no one asked
for the Ask hand-off in that flow. That silent focus jump is exactly
the behavior the report-member flow (ADR 0078) does want, so the fix
threads a focusAskOnLand flag through PostDetailPopup -> KeymanPanel
and only lets the drill claim focus for the report-member open.

Confirmed pre-existing on this branch's own pristine tip (reproduced
before merging anything else in), not introduced by any local change.
@seonghobae
seonghobae force-pushed the feat/calendar-open-focus-event-lineage-v2140 branch from 736721f to b7ade01 Compare August 20, 2026 02:50
@seonghobae
seonghobae force-pushed the feat/board-weekly-voc-open-event-lineage-v2130 branch from 7ef8d4e to 2ee8378 Compare August 20, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant