Skip to content

fix(ui): keep digest disclosure panels and 24px targets (v0.86.3) - #155

Closed
cursor[bot] wants to merge 3 commits into
feat/role-responsibility-agent-ontologyfrom
cursor/bc-3cfb7760-e961-4187-b6da-e094aafa8a4c-d9f3
Closed

fix(ui): keep digest disclosure panels and 24px targets (v0.86.3)#155
cursor[bot] wants to merge 3 commits into
feat/role-responsibility-agent-ontologyfrom
cursor/bc-3cfb7760-e961-4187-b6da-e094aafa8a4c-d9f3

Conversation

@cursor

@cursor cursor Bot commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

Why this exists

#139 (cf8c2e8) repaired APG disclosure and 24px targets, but it cannot land on the current feat/role-responsibility-agent-ontology tip. That base already shipped 0.86.1 as embedded data:image rendering and 0.86.2 as R&R catalog-id walks (#141). #139 still claims 0.86.1 and conflicts in CHANGELOG.md and CLAUDE.md.

Change (v0.86.3)

#131 still owns the live write-clock comparison. #134 still owns retention purge. #136 still owns the Storybook runner.

Verification

  • cd frontend && pnpm run lint && pnpm run test && pnpm run build — 69 tests passed, including a closed panel that remains hidden with a live aria-controls target, Enter/Space reveal, the revealed next-action sentence, and the pending-run “has not started yet” detail copy.

Merge gates

References

World Wide Web Consortium. (2018). Accessible name and description computation 1.1 (W3C Recommendation). https://www.w3.org/TR/accname-1.1/

World Wide Web Consortium. (2024). Web content accessibility guidelines (WCAG) 2.2 (W3C Recommendation). https://www.w3.org/TR/WCAG22/

World Wide Web Consortium. (n.d.). Disclosure (show/hide) pattern. ARIA Authoring Practices Guide. https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/

Open in Web View Automation 

cursoragent and others added 2 commits August 16, 2026 16:21
Rebase the APG disclosure onto #141 so closed panels stay in the
document with hidden, each prefix meets WCAG 2.5.8, and 0.86.1 image
rendering plus 0.86.2 catalog-id walks stay on the base. Prefer this
head over #139 cf8c2e8.

Co-authored-by: Seongho Bae <[email protected]>
After Request a lineage reconstruction, the opened Pending detail now
repeats that reconstruction has not started yet so the operator can
confirm the cutoff corpus before waiting for a tree.

Co-authored-by: Seongho Bae <[email protected]>
@cursor
cursor Bot requested a review from seonghobae August 16, 2026 16:24

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Successor of #139 for the digest-disclosure slice.

Verified locally: cd frontend && pnpm run lint && pnpm run test && pnpm run build — 69 tests passed, including closed hidden panels with live aria-controls targets, Enter/Space reveal, the revealed next-action sentence, and pending-run “has not started yet” detail copy.

Retarget required before merge. open_git_pr opened this against main. The merge gate is feat/role-responsibility-agent-ontology (#74). GitHub write MCP was unavailable in this run, so the base was not changed here. Change the base to feat/role-responsibility-agent-ontology before review-and-merge. Do not merge to protected main before #74.

Prefer this head over #139 cf8c2e8 and over #135. #131 still owns the write-clock. #134 still owns retention purge. #136 still owns the Storybook runner.

Independent review required. Do not self-approve.

View PR

Open in Web View Automation 

Sent by Cursor Automation: Fix Issues

@seonghobae
seonghobae changed the base branch from main to feat/role-responsibility-agent-ontology August 16, 2026 16:24
Prefer the v0.86.3 disclosure successor over #139. Write-clock stays
#150; pending-copy stays #149; retention/Storybook stays #154.

Co-authored-by: Seongho Bae <[email protected]>

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale comment

Digest-disclosure successor of #139, now based on feat/role-responsibility-agent-ontology (#141 tip).

Verified locally: cd frontend && pnpm run lint && pnpm run test && pnpm run build — 69 tests passed, including closed hidden panels with live aria-controls targets, Enter/Space reveal, “Match the revealed digest to the API payload,” and pending-run “has not started yet” on the opened detail.

Prefer this head (2daed45, v0.86.3) over #139 cf8c2e8 and over #135. Do not merge #139. Write-clock stays #150. Kind-specific pending copy stays #149. Retention purge + Storybook tokens stay #154.

Independent review required. Do not self-approve. Do not merge to protected main before #74.

View PR

Open in Web View Automation 

Sent by Cursor Automation: Fix Issues

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment

#155 is no longer the landing vehicle for digest disclosure.

#148 (39ed6eb) landed on feat/role-responsibility-agent-ontology. This head (2daed45) now conflicts in CLAUDE.md, CHANGELOG.md, App.tsx, and App.test.tsx. A rebase that keeps the older pending-copy helper also duplicates the next-action sentence on the opened detail.

Prefer #158 (7726621) over this PR, over #139 cf8c2e8, and over #135. #158 rebases the APG disclosure and 24px targets onto #148, keeps the single kind-specific pending line, and types the pending-detail query so tsc -b passes.

Do not merge #155. Independent review stays on #158. Do not self-approve. Write-clock stays #150. Retention purge + Storybook tokens stay #154. Do not reopen pending-copy (#149/#146); that slice landed as #148.

open_git_pr opened #158 against main. Retarget #158 to feat/role-responsibility-agent-ontology before review-and-merge. Do not merge to protected main before #74.

View PR

Open in Web View Automation 

Sent by Cursor Automation: Fix Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants