fix(ui): keep digest disclosure panels and 24px targets (v0.86.1) - #139
Conversation
aria-label on the digest paragraph hid the prefixes from assistive technology. Move the label to a group, keep prefixes as visible text, and put the full digest on hover. Tell the operator that a cutoff title opens the live body so they compare it with the run clock. Co-authored-by: Seongho Bae <[email protected]>
Co-authored-by: Seongho Bae <[email protected]>
Hover title tooltips were the only way to read a full digest, so keyboard and assistive-technology operators could not match the API payload. Turn each prefix into an APG disclosure button. Co-authored-by: Seongho Bae <[email protected]>
The ontology branch landed audible prefixes and pending-run create. Keep those slices and disclose full digests from the keyboard as v0.85.1 so the operator can match the API payload without a hover. Co-authored-by: Seongho Bae <[email protected]>
Closed APG disclosure panels left the document, so aria-controls pointed at nothing. Keep each panel hidden in place, size the prefix to the WCAG 2.5.8 24px minimum, and tell the operator to match the revealed digest to the API payload. Co-authored-by: Seongho Bae <[email protected]>
Keep closed APG digest panels in the document and 24px prefix targets after the team/organization related-node walk landed. Co-authored-by: Seongho Bae <[email protected]>
seonghobae
changed the title
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Prefer #155 (df08690, v0.86.3) over this head.
This #139 tip (cf8c2e8) still claims 0.86.1 and is CONFLICTING on current feat/role-responsibility-agent-ontology. That base already shipped 0.86.1 as embedded data:image rendering and 0.86.2 as R&R catalog-id walks (#141). Do not land this SHA.
The disclosure slice itself is sound: closed panels stay in the document with hidden, aria-controls has a target, prefixes meet the 24px floor, and the revealed next action is “Match the revealed digest to the API payload.” #155 rebases that onto #141 and keeps the pending-run “reconstruction has not started yet” copy on the opened detail.
Do not merge #139. Do not merge #135 in parallel. Independent review of #155 is still required — this automation will not self-approve.
Sent by Cursor Automation: Fix Issues
Prefer the v0.86.3 disclosure successor over #139. Write-clock stays #150; pending-copy stays #149; retention/Storybook stays #154. Co-authored-by: Seongho Bae <[email protected]>
2 participants
Why this exists
#135 discloses full analysis-run digests from the keyboard, but a closed panel leaves the document.
aria-controlsthen points at nothing, so a screen-reader shortcut to the digest fails (WAI-ARIA APG Disclosure). The prefix button also usespadding: 0at meta size, so the pointer target can fall under 24px (WCAG 2.2 SC 2.5.8).Change (v0.86.1)
3c17fd3) so this head includes the team/organization related-node walk.hidden.aria-controlsalways has a target.Code/Configprefix is at least 24×24 CSS pixels.Prefer this head over #135. #131 still owns the live write-clock comparison. #134 still owns retention purge. #136 still owns the Storybook runner.
Verification
cd frontend && pnpm run lint && pnpm run test && pnpm run build— 60 tests passed after the feat: walk team and organization related nodes (v0.85.0) #122 merge, including a closed panel that remainshiddenwith a livearia-controlstarget, Enter/Space reveal, and the revealed next-action sentence.Merge gates
feat/role-responsibility-agent-ontology(Role, responsibility, and agent ontology (v2.10.0) #74), notmain.mainbefore Role, responsibility, and agent ontology (v2.10.0) #74.References
World Wide Web Consortium. (2018). Accessible name and description computation 1.1 (W3C Recommendation). https://www.w3.org/TR/accname-1.1/
World Wide Web Consortium. (2024). Web content accessibility guidelines (WCAG) 2.2 (W3C Recommendation). https://www.w3.org/TR/WCAG22/
World Wide Web Consortium. (n.d.). Disclosure (show/hide) pattern. ARIA Authoring Practices Guide. https://www.w3.org/WAI/ARIA/apg/patterns/disclosure/