Repository navigation
Conversation
…ync; correct the german word "programm" to "progam"
Contributor
|
This seems good to me but since I'm unfamiliar with ParamSpec I can't tell if there are any undesirable effects. @cpr-bar can you evaluate this? |
Contributor
|
I got issues running the examples but that should be caused by your branch being behind our repo rather than the change (that issue was fixed recently) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds a small
blocking_wrapperdecorator and uses it to generate the blocking (sync) version of the*_asyncmethods inCRIController, replacing the hand-writtenreturn _run_sync(self.xxx_async(...))wrappers.Function names with the german spelling 'programm' are changed into 'program'.
Details
ParamSpec, so IDEs still show the real parameters and return type of each sync method (e.g.set_dout(id: int, value: bool)).Blocking wrapper around :meth:CRIController.xxx_async``.Notes for review
set_dout("a")) as errors. With the generated methods it may not, so such mistakes only show up at runtime or in an external type check.Testing
start_program.pyand relative_move pass