Repository navigation
Conversation
Gunoshozo
force-pushed
the
cclcc-switch
branch
6 times, most recently
from
September 17, 2026 11:45
69fc533 to
e7d16b2
Compare
3 tasks
Gunoshozo
force-pushed
the
cclcc-switch
branch
9 times, most recently
from
September 19, 2026 09:32
184cff4 to
d06aa32
Compare
Gunoshozo
marked this pull request as ready for review
September 19, 2026 09:51
Gunoshozo
requested review from
Enorovan,
KKhanhH and
PringlesGang
and removed request for
KKhanhH and
PringlesGang
September 19, 2026 09:51
PringlesGang
requested changes
Sep 20, 2026
PringlesGang
left a comment
PringlesGang
left a comment
Member
There was a problem hiding this comment.
Insane that you got so much done so quickly. Gfj dude
Member
There was a problem hiding this comment.
Should these be ScriptHandled? If the Switch couldn't handle the PS4 assets
Contributor
Author
There was a problem hiding this comment.
I had an impression that ScriptHandled should be set as a part of the patch when targeting switch as a platform for Impacto. Cause if you have enough ram on a PC/Android it's better to preload everything and don't use ScriptHandled
KKhanhH
requested changes
Sep 20, 2026
KKhanhH
left a comment
KKhanhH
left a comment
Collaborator
There was a problem hiding this comment.
Still have a few more files left to review
KKhanhH
reviewed
Sep 21, 2026
KKhanhH
requested changes
Sep 21, 2026
…- TextLayoutPlainString now has the same string bit depth as StringEncodingType (tips and save menu are not crashing) - Fixes + some vars - Move switch specific stuff into Inst - Fix inst table value to fix control flow
…plicit conversions - Added variant of vectors to the text parser (couple of new visits, lost couple of constexpr ;_; ) - Parser instances will be init after string type configuration from profile
…trings - TextLayoutPlainString now has the same string bit depth as StringEncodingType (tips and save menu are not crashing) - Fixes + some vars - Move switch specific stuff into Inst - Fix inst table value to fix control flow
…and BGload logic workaround - Fix BGM restoration on load - Fix yes/no trigger
…hout explicit conversions - Added variant of vectors to the text parser (couple of new visits, lost couple of constexpr ;_; ) - Parser instances will be init after string type configuration from profile
…hout explicit conversions - Added variant of vectors to the text parser (couple of new visits, lost couple of constexpr ;_; ) - Parser instances will be init after string type configuration from profile
…thout explicit conversions - Added variant of vectors to the text parser (couple of new visits, lost couple of constexpr ;_; ) - Parser instances will be init after string type configuration from profile" This reverts commit f91d1af
Gunoshozo
force-pushed
the
cclcc-switch
branch
from
October 10, 2026 19:54
1cf738b to
2f27fe0
Compare
PringlesGang
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.