Skip to content

Complete Paper review readonly keyboard shortcuts - #2788

Merged
Chris0Jeky merged 6 commits into
mainfrom
issue-1968/review-readonly-shortcuts
Sep 8, 2026
Merged

Complete Paper review readonly keyboard shortcuts#2788
Chris0Jeky merged 6 commits into
mainfrom
issue-1968/review-readonly-shortcuts

Conversation

@Chris0Jeky

@Chris0Jeky Chris0Jeky commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Refs #1968. Paper review keeps provenance P and preview diff Space usable while the Request edit editor owns the shared decision lock; Apply, reject, defer, and Request edit remain blocked. The shared shortcut ledger includes live Paper D and Space bindings, removes retired G T while preserving bare T, gates Review and help rows on newAutomation, and the notation guard covers spaced Ctrl + and Control+. Verification: focused Vitest 334 passed; npm run typecheck passed; npm run build passed; targeted eslint passed; git diff --check passed. Stacked on issue-2215/paper-review-stability for coordinator retargeting.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T00:18:08.316715Z f1be2aa New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 02564869e0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/taskdeck-web/src/views/paper/PaperReviewView.vue
Base automatically changed from issue-2215/paper-review-stability to main September 7, 2026 23:00
@Chris0Jeky Chris0Jeky moved this from Pending to Review in Taskdeck Execution Sep 7, 2026
@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Review round 1 fixed the connector reachability finding at 6211f5d04: revision-field typing preserves P/Space, while native tab-focusable inspection controls invoke the same read-only provenance/diff handlers. Verified locally: 316 focused shortcut/review tests, npm run typecheck, zero-warning scoped ESLint, and git diff --check. Original head checks were remeasured before this push: no failed conclusion; Frontend Unit and required gate were green, while Backend Unit Windows and API Integration Ubuntu were still in progress. This push restarted head checks. Full frontend Vitest in default env, Mock Playwright, runtime screenshots, and backend lease checks remain pending with the active lease owner; this PR is not merge-ready yet.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6211f5d041

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: baa4a80584

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread frontend/taskdeck-web/src/utils/keyboardShortcuts.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f1be2aa474

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Session wrap-up: source is pushed at f1be2aa and the disposable worktree was removed after identical snapshot-content verification, clean tracked status, and upstream-head equality. Browser proof remains at C:\Users\Public\codex-shell-home\taskdeck-1968-shortcut-proof; additional logs and trace were copied into its saved-worktree-output directory. No owned runtime listeners remain. Current CI/review gates and P2 follow-ups are saved in PR #2802.

@Chris0Jeky

Copy link
Copy Markdown
Owner Author

Independent Terra review, round 1 at head f1be2aa against base/merge-base 8d7cd7d: no confirmed Critical/High finding. The connector findings were triaged once: the editor reachability finding was fixed; the remaining narrow layout, disabled-automation help text, and provenance-scroll items are correctly retained as tracked P2 usability follow-ups under #1968/#2007. Local evidence: focused shortcut/review suite (6 files, 316 passed) and npm run typecheck (passed). No additional fix batch is warranted.

@Chris0Jeky
Chris0Jeky merged commit ca6bc39 into main Sep 8, 2026
35 checks passed
@Chris0Jeky
Chris0Jeky deleted the issue-1968/review-readonly-shortcuts branch September 8, 2026 00:58
@github-project-automation github-project-automation Bot moved this from Review to Done in Taskdeck Execution Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant