Keep Review shortcut help and inspection labels truthful - #2827
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Independent Terra SHIP ataaa510bd3615f9b9be012a7ac9b5e13b8b3202b0/base22fcac405: all six rows obey existingnewAutomation availability, disabled route matches hiddenhelp, corrected labelkeys exist in en/it/es. Reviewer inspected all four changedfiles plus route/keymap/flag/catalog context and ran the twochanged specs:22passed. No HIGH/CRITICAL or lower finding. Initial handoff saidfivefiles; actualdiffisfour, informational and PRbodycorrect. Closingrefs0 and ProjectReview/PriorityII verified; hostedqualification pending. |
|
Completed source checkout removed with plain git worktree remove after clean tracked state, remote-head ancestry and no-active-process checks. Unique .tmp verification/review material copied OUT to C:\Users\jekyt\source\Taskdeck.claude\local\milestone-20260909\preserved-2827\verification-and-review; ignored dist/node_modules were rebuildable. Headaaa510bd and branch remain remote. Primary and unrelated worktrees preserved; hosted qualification remains pending. |
|
Delivery is now held for combined candidate #2830 at 3923500 on main06bd4d18e. It preserves the reviewed source commit, passed the full combined backend9096/5skip and frontend6243/3skip suites, browser SC-005, builds/lint/doc links, and fresh Terra integration review. Do not merge sources independently while the combined exact-base/head hosted gate qualifies. Once #2830 lands, coordinator will verify inclusion and reconcile these source PRs. Existing tracked MEDIUMs remain open; no new feature changes added. |
|
Delivered through #2830, merged as cca0716. Main tree c73859a9ba712192935fc13586260ab61a9fb22c exactly equals qualified39235004b; all three source heads are verified ancestors. GitHub automatically marked #2827/#2828/#2829 merged through preserved commits. Required ci-required.yml run34358736114 passed at the exact head/base, fresh Terra review passed and no unresolved threads remained. Tracked MEDIUMs remain follow-ups; no full parent-issue completion claim. |
1 participant
When Review is disabled, the keyboard map still advertises six Review actions. Those rows now use the existing
newAutomationavailability filter, while enabled Review retains every binding. The revision editor also uses the existing translated provenance/preview labels instead of missing translation keys. This keeps help truthful and reduces navigation friction without changing key dispatch, decision locking, or Apply.Refs #1968. Four scoped files: registry metadata, editor label references, and their two rendered tests. This is a tracked follow-up after merged #2788; parked candidates remain untouched.
Validation at
aaa510bd3615f9b9be012a7ac9b5e13b8b3202b0, base22fcac405946e226c136e2fd52be3b8cdf9ecca7:npx --no-install vitest --run --maxWorkers=2: 393 files, 6230 passed, 3 skipped; exit 0.No browser was added for registry metadata/rendered labels. The existing revision-lock keyboard browser test was separately observed passing in #2826; it is not new evidence from this slice. Existing localhost5000 connection-refused test noise and toastStore dynamic-import build warning remain unchanged.
OUTSTANDING_TASKS.md and canonical docs are unchanged. Narrow action-row overflow, disclosure placement and notation guard follow-ups remain on #1968; no claim that the full issue or milestone is complete.