Skip to content

emulator answers FRAME before ACF is loaded #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
astronomerdave merged 2 commits into from
Oct 13, 2026
Merged

emulator answers FRAME before ACF is loaded #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e88f63
bugfix: emulator answers FRAME before ACF is loaded as real Archon does
Oct 13, 2026
4530ce5
bugfix: open fails when FRAME fails instead of replying DONE
Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion camerad/archon_controller.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,9 @@ namespace Camera {

// Ensures these values are set on startup
//
this->get_frame_status();
if (this->get_frame_status() != NO_ERROR) {
throw std::runtime_error("getting FRAME status");
}

if (this->lastframe==0) {
for (int i=0; i<MAXNBUFS; ++i) {
Expand Down
44 changes: 29 additions & 15 deletions emulator/emulator-archon.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ namespace Archon {
exit(1);
}

// Start with the frame buffers a real Archon reports at power-up,
// before any ACF has been loaded.
//
this->set_bigbuf( false );

struct timespec ts; // container for the time
if ( clock_gettime( CLOCK_REALTIME, &ts ) != 0 ) {
this->init_time = 0;
Expand Down Expand Up @@ -345,11 +350,6 @@ namespace Archon {
std::string timenow;
std::stringstream framestr;

if ( this->image->activebufs == -1 ) {
std::cerr << get_timestamp() << function << "ERROR: activebufs undefined. Check that an ACF was loaded and that it contains BIGBUF=x\n";
return ERROR;
}

this->timer_report( this->frame.timer );

framestr << "TIMER=" << this->frame.timer << " "
Expand Down Expand Up @@ -497,6 +497,29 @@ namespace Archon {
/***** Interface:fetch_data *************************************************/


/***** Interface::set_bigbuf ************************************************/
/**
* @brief sets the frame buffer layout selected by BIGBUF
* @param[in] bigbuf true for BIGBUF=1, false for BIGBUF=0
*
* Sets the number of active frame buffers and their base addresses.
*
*/
void Interface::set_bigbuf( bool bigbuf ) {
this->bigbuf = bigbuf;
this->image->activebufs = ( this->bigbuf ? 2 : 3 );
this->frame.bufbase.at(0) = 0xA0000000;
if ( this->bigbuf ) {
this->frame.bufbase.at(1) = 0xD0000000;
}
else {
this->frame.bufbase.at(1) = 0xC0000000;
this->frame.bufbase.at(2) = 0xE0000000;
}
}
/***** Interface::set_bigbuf ************************************************/


/***** Interface:wconfig ****************************************************/
/**
* @brief handles the incoming WCONFIG command
Expand Down Expand Up @@ -593,16 +616,7 @@ namespace Archon {
// Some keywords in this category are used to assign certain class variables
//
if ( key == "BIGBUF" ) {
this->bigbuf = ( std::stoi(value)==1 ? true : false );
this->image->activebufs = ( this->bigbuf ? 2 : 3 );
this->frame.bufbase.at(0) = 0xA0000000;
if ( this->bigbuf ) {
this->frame.bufbase.at(1) = 0xD0000000;
}
else {
this->frame.bufbase.at(1) = 0xC0000000;
this->frame.bufbase.at(2) = 0xE0000000;
}
this->set_bigbuf( std::stoi(value)==1 ? true : false );
}

else if ( key == "TAPLINES" ) {
Expand Down
1 change: 1 addition & 0 deletions emulator/emulator-archon.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ namespace Archon {
long wconfig(std::string buf); //!<
long rconfig(std::string buf, std::string &retstring);
long write_parameter(std::string buf);
void set_bigbuf( bool bigbuf ); //!< sets frame buffer count and base addresses
static void dothread_expose( Archon::Interface &iface, int numexpose );

// TODO ***** below here need to check what's needed **********************************************************
Expand Down
Loading