Repository navigation
emulator answers FRAME before ACF is loaded - #53
Merged
Merged
Conversation
starts in the BIGBUF=0 buffer state through set_bigbuf(), which the BIGBUF handler now also calls
astronomerdave
requested review from
mikelangmayr,
prkrtg and
scizen9
as code owners
October 13, 2026 18:27
mikelangmayr
approved these changes
Oct 13, 2026
prkrtg
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug fix
The emulator replied
?toFRAMEuntil an ACF setBIGBUF. A real Archon answersFRAMEstraight after power-up, with three buffers at theBIGBUF=0addresses. camerad'sopensendsFRAME, so everyopenbeforeloadlogged threeERRORlines, and CI passed because it checks only theDONEreply.The emulator now starts in the
BIGBUF=0state. TheBIGBUFhandler's assignments move intoset_bigbuf(), which the constructor also calls, so the buffer addresses have one source. Theactivebufs == -1check inframe_reportis removed, since that state can no longer occur.camerad still ignores a failedFRAMEinconnect(). That will be a separate change.connect()now throws whenget_frame_status()fails, as it already does forSYSTEM, soopenrepliesERROR.