Skip to content

sequencerd: auto-ontarget on by default; require the cass ring at the commanded angle - #500

Closed
cfremling wants to merge 1 commit into
feat/sequencer-pick-at-readoutfrom
feat/auto-ontarget-ring
Closed

cfremling wants to merge 1 commit into
feat/sequencer-pick-at-readoutfrom
feat/auto-ontarget-ring

Conversation

@cfremling

@cfremling cfremling commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator
  • TCS_AUTO_ONTARGET defaults to yes.
  • The automatic ontarget also requires |TCS cass angle − RINGGO angle| < TCS_AUTO_ONTARGET_CASS (0.05 deg) on the same two consecutive 1 Hz reads. ACAM's goal is computed from the cass angle at the acquire, about 8.5" per degree of ring still to turn; settled rings read within 0.022 deg of the command (73 targets, 2026-10-19).
  • When everything but the ring has held for 20 s, one warning tells the operator to press ontarget once the ring is in place.

Stacked on #499 (base branch feat/sequencer-pick-at-readout), whose ontarget handling it extends.

Jira: PAL-144. Tested on sky 2026-10-28/29 UT using branch cf/summit-20261020: 17 of 18 slews continued automatically, 1.2–2.0 s after tcsd reported tracking; the operator pressed ontarget for the first. No ring warning was raised.

🤖 Generated with Claude Code

… commanded angle

TCS_AUTO_ONTARGET defaults to yes. The automatic ontarget now also
requires |TCS cass angle - RINGGO angle| < TCS_AUTO_ONTARGET_CASS
(0.05 deg) on the same two consecutive reads: ACAM's goal is computed
from the cass angle at the acquire, about 8.5" per degree of ring still
to turn. When everything but the ring has held for 20 s, one warning
tells the operator to press ontarget once the ring is in place.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T14:17:10.467379Z 8271514 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cfremling

Copy link
Copy Markdown
Collaborator Author

Combined into #503 with the changes it depends on, so that every open PR applies to main on its own; its change is one commit of #503. Closing.

@cfremling cfremling closed this Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants