Skip to content

camerad, sequencerd: stop and abort an NEXP>1 series - #501

Closed
cfremling wants to merge 1 commit into
feat/auto-ontarget-ringfrom
feat/sequencer-nexp-stop-abort
Closed

cfremling wants to merge 1 commit into
feat/auto-ontarget-ringfrom
feat/sequencer-nexp-stop-abort

Conversation

@cfremling

@cfremling cfremling commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

seq stop reached camerad only while the EXPOSE wait was set, i.e. during sub-exposure 1 of an NEXP>1 series, and after an abort camerad could still start the next sub-exposure.

  • sequencerd accepts stop for the whole series of the current target (after the first sub-exposure, camerad not READY covers the rest) and no longer clears a cancel.
  • camerad ends the series after the frame in progress, cut short if it is integrating with 5 s or more left, instead of starting the next sub-exposure. An abort sets the remaining count to zero, and a continuation cannot undo a stop.
  • A cancelled exposure's remaining PIXELCOUNT messages cannot set the READOUT wait later.
  • A command that finds a frame write still finishing (READY is published a few ms before the last write ends) waits up to 2 s for it instead of being refused.

Stacked on #500 (base branch feat/auto-ontarget-ring); uses #499's readout state.

Jira: PAL-142. Not yet tested on sky with NEXP>1: all 18 exposures on 2026-10-28/29 were NEXP=1. A stop on a single exposure that night ended the integration as expected.

🤖 Generated with Claude Code

stop: the sequencer accepts it for the whole series of the current
target (the EXPOSE wait covers only the first sub-exposure; camerad not
READY covers the rest) and no longer clears a cancel. camerad ends the
series after the frame in progress, cut short if it is integrating with
5 s or more left, instead of starting the next sub-exposure. abort no
longer starts the next sub-exposure either. A cancelled exposure's
remaining PIXELCOUNT messages cannot set the READOUT wait later.

camerad waits for the last frame's FITS write before acting on the next
command after READY.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-29T14:15:34.781751Z 7a22f56 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cfremling

Copy link
Copy Markdown
Collaborator Author

Combined into #503 with the changes it depends on, so that every open PR applies to main on its own; its change is one commit of #503. Closing.

@cfremling cfremling closed this Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants