Repository navigation
test: bind desktop fixtures to the current host and renderer - #956
Merged
Merged
Conversation
23 tests in the small gate's Node batch fail on main, because these fixtures run slices of host.js or read the renderer and fell behind them. Load the real names the slices now reach, move an end marker that left host.js, reach the probe path #941 moved behind directReconnect, and re-bind the focused-cache shape checks to the static pending bubble. Adds one check that the bubble stays out of a saved picture. Tests only; nothing is deleted or skipped.
Collaborator
Author
|
Combined control passed on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 23 Node failures in the small gate's desktop batch that are red on main and block #951. This PR changes tests only: no product, Bend, law, CLI or guard change, and nothing is deleted or skipped.
All 23 fail on pure main
64eca09231(Boatj20261104202440-1495217, 388 tests, 365 pass). With this change the same batch passes 389 of 389 (j20261104204829-1681554); the extra test is the new pending check below.Why they failed
These tests run slices of
src/web/host.jsin avm, so a slice can't seehost.js's imports or the top-level names outside it. Later commits added uses of those names inside the slices. Several failures were hidden: each fix exposed the next, andThinHost's barecatchturned one ReferenceError intoView request could not be sent.host-thin-startupdirectReconnecta44e1e11a9reconnect.jsPHONE_TITLEShost.jssecretSaves36d45ab07SecretSaveHost; itsbuildandsendthrow if usedphoneReplyWatchhost.jsphoneRequest,PHONEc12327204phoneRequest;PHONE: falseas a desktop inputthin-search-uiPHONE_TITLES,softFocustouch-focus.jsexportthin-view-holdretireAllowance(lefthost.jstrace("dom",; the sliced lines are the samefocused-cachemsg assistant live138b2731ePlease review these two closely: they change what a test expects or sets up
focused-cache.test.cjs"normal live DOM shape": Restore account selection and combine requested local UI updates #680 made the live row a static pending bubble, which is the documented contract (docs/active-threads-load.md:85) and is pinned bytest/signal_ui_test.bend. The same three shape checks (class, body, nodata-id) now readView.pending.node. A new test checks that the bubble stays out of a saved picture.host-thin-startup"late retry probe": Web: reconnect at once when the page comes back from the background #941 connects straight to the socket on a reconnect, so/hellois only probed oncedirectFailsreachesDIRECT_TRIES. The test now sets that state to reach the same race. Its assertions are unchanged, and itslegacybranch still reproduces the old extra close.Left for the owners (not changed here)
focused-cache.jsstill captures streaming rows by classlive, which nothing in the normal web renderer now emits.viewsEveris set when view mode starts (host.js:3490), not at the first view asreconnect.js's comment says. The effect is bounded byDIRECT_TRIES.ThinHost's barecatcharoundapi.sendhides programming errors like these asView request could not be sent. Failing tests also left timers running, which is why the batch hung instead of finishing.Merging: this PR and #955 each need the other for the guards to pass. Control on the combined tree is reported below once it finishes.
cc @jlcjak: these fixtures fell behind the phone-web and reconnect work. Please check the
PHONE_TITLES,phoneReplyWatchanddirectReconnecthandling matches what you intended.