Repository navigation
ci: pin release-bootstrap to the 0.14.1 service producer - #955
Merged
Merged
Conversation
Collaborator
Author
|
This PR alone still fails the guards on the 23 baseline Node failures ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the stale producer pin that fails
test_workflow_pins_this_component_producer(test/tools/release_bootstrap_test.py:206) on main and blocks #951's small gate.The whole change is one literal in
release-bootstrap.yml:--producer-sha256goes from29ba0604…to86722ad1…. There is no producer, runtime, Bend, law or CLI change.Why the hash changed
scripts/service-release.pybecame86722ad1…in2409055c91("release: bind 0.14.1 producer and package version metadata"), merged by Bind 0.14.1 metadata and require packaged Windows standard-user smoke #911 as0752c0c7e7.VERSION = "0.14.0"to"0.14.1". This was intended: the same commit moves the 0.14.1 version across the workflows and release metadata.release-bootstrap.ymlbut not the hash, so the pin stayed at29ba0604…, the v0.14.0 producer. The new hash is correct, and only the pin was left behind.v0.14.1(e564f904eb) carries the same mismatch.Why nothing caught it
ci.ymlis manual and nightly only, and that is where this test runs. It was not among the runs on Bind 0.14.1 metadata and require packaged Windows standard-user smoke #911.release-bootstraprun one564f904ebsucceeded with itsjsandjs-runtimejobs skipped, soservice-runtime.py's hash check never ran.869919ffb3,72f7e5694b,2409055c91). A future 0.14.2 bump will need a fresh pin, computed from that commit's actual producer.release-runtime-recovery.yml:92(ae60a25a…): left unchangede06a9052….cfdfc67bbf(Bump release packaging to 0.14.0 (Alpha) #825, the 0.14.0 packaging merge), whose producer is exactlyae60a25a….86722ad1…would break that frozen ref and gain nothing.Component producer hash mismatch, so it fails closed, and no test binds it. Recovering a later frozen commit needs that commit's own hash.