Repository navigation
v36: Save ink into file works into a different board copy in Chrome - #39
Merged
Merged
Conversation
Two problems when saving ink from one board copy into another (say pet_board_inked.html into pet_board_clean.html): - Chrome only asks "allow editing this file?" right after a tap, and our own "different file name, are you sure?" box used that tap up, so Chrome refused without asking. Now the permission question comes straight after the file is picked, before ours. If the browser still refuses, the File menu stays open and the button says "Tap again to allow". - The ink in a file was dated by when it was last drawn, so a browser that had used the clean copy since (even to try it out and clear it) showed its own empty copy instead. Ink written into a file now records when it was written, and that counts. New tests/savefile.spec.js covers both with a stand-in for Chrome's file permission rules; all three tests fail on the old code. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Ad4FSbRKTiPjbSKtqwcUSJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes saving ink from one board copy into another (e.g.
pet_board_inked.html→pet_board_clean.html), which worked in Edge but not Chrome.1. Chrome never asked for permission. Chrome only shows "allow editing this file?" right after a tap. OverBoard's own "different file name, are you sure?" box came first and used that tap up, so Chrome refused silently. Now:
2. The saved copy opened in Chrome showed no ink. Ink in a file was dated by when it was last drawn. If Chrome had used the clean copy since (even to try it and clear it), its own empty browser copy counted as newer and won. Ink written into a file now also records when it was written (
w), and that time counts on load.Tests: new
tests/savefile.spec.js(the overlay's Save ink into file had no tests) with a stand-in that follows Chrome's permission rule. All three tests fail on the old code and pass now. The related overlay, language, HTML, history, Select and toolbar suites pass locally.Version v36, CHANGELOG and ARCHITECTURE notes updated.
Generated by Claude Code