Repository navigation
v37: Save ink into file says so when a file can't take ink - #40
Merged
Merged
Conversation
Picking a file without OverBoard in it used to do nothing visible (only a status line message). Now the button says Not saved!, the message says in plain words to drop the file on the app first, and OverBoard checks the file before asking the browser for permission to edit it, so the browser never asks about a file that won't be written to. Also makes the savefile test that rewrites a file and reopens it skip the browser cache, so it can't read the old copy when both happen in one second. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01Ad4FSbRKTiPjbSKtqwcUSJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow-up to #39 (HTML overlay, Settings & help ▸ Save ink into file).
Picking a file that doesn't have OverBoard in it used to look like nothing happened. Now:
The file is never touched (it wasn't before either).
Tests: a new case in
tests/savefile.spec.js(button, message, no permission prompt, file unchanged). The test that rewrites a file and reopens it now skips the browser cache: the local test server only knows file times to the second, so it could serve the old copy under load. The related suites pass locally, run twice each.Generated by Claude Code