Skip to content

Fix configured PHP benchmark workload reuse #2447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chubes4 merged 1 commit into from
Aug 31, 2026
Merged

Fix configured PHP benchmark workload reuse #2447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/runtime-playground/src/bench-command-handlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,6 +1666,7 @@ function wp_codebox_bench_assert_required_observations(array $workload, array $p
}

function wp_codebox_bench_run_configured_workload(array $workload, string $plugin_path) {
static $php_file_results = array();
$steps = wp_codebox_bench_workload_run_steps($workload);
$payload = array('metrics' => array(), 'metadata' => array(), 'artifacts' => array(), 'steps' => array(), 'diagnostics' => array());
if (isset($workload['metadata']) && is_array($workload['metadata'])) {
Expand All @@ -1679,7 +1680,10 @@ function wp_codebox_bench_run_configured_workload(array $workload, string $plugi
if ($type === 'php') {
if (isset($step['file']) && is_string($step['file'])) {
$file = $plugin_path . '/' . ltrim($step['file'], '/');
$callable = require $file;
if (!array_key_exists($file, $php_file_results)) {
$php_file_results[$file] = require $file;
}
$callable = $php_file_results[$file];
$result = is_callable($callable) ? $callable() : $callable;
} else {
$result = null;
Expand Down
32 changes: 32 additions & 0 deletions tests/bench-command-step-behavior.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,38 @@ assert.match(requiredObservationGate[0], /"step_count":0/)
assert.match(requiredObservationGate[1], /observation:rest-db-query-profiler/)
assert.equal(requiredObservationGate[2], "report")

const configuredPhpFileIterations = await withTempDir("wp-codebox-configured-php-file-", async (directory) => {
const workloadFile = join(directory, "workload.php")
const phpTestFile = join(directory, "configured-php-file.php")
await writeFile(
workloadFile,
`<?php
$GLOBALS['wp_codebox_test_load_count'] = ($GLOBALS['wp_codebox_test_load_count'] ?? 0) + 1;
function wp_codebox_test_configured_workload_result(): array {
$GLOBALS['wp_codebox_test_call_count'] = ($GLOBALS['wp_codebox_test_call_count'] ?? 0) + 1;
return array('metrics' => array('calls' => $GLOBALS['wp_codebox_test_call_count']));
}
return 'wp_codebox_test_configured_workload_result';
`,
)
await writeFile(
phpTestFile,
`<?php
${configuredWorkloadHelpers}
$workload = array('run' => array(array('type' => 'php', 'file' => 'workload.php')));
wp_codebox_bench_run_configured_workload($workload, ${JSON.stringify(directory)});
$payload = wp_codebox_bench_run_configured_workload($workload, ${JSON.stringify(directory)});
echo json_encode(array(
'loads' => $GLOBALS['wp_codebox_test_load_count'],
'calls' => $GLOBALS['wp_codebox_test_call_count'],
'metrics' => $payload['metrics'],
), JSON_UNESCAPED_SLASHES);
`,
)
return runPhpFileJson<{ loads: number; calls: number; metrics: { calls: number } }>(phpTestFile)
})
assert.deepEqual(configuredPhpFileIterations, { loads: 1, calls: 2, metrics: { calls: 2 } })

const externalHttpGuardrailPayload = await withTempDir("wp-codebox-external-http-guardrail-", async (directory) => {
const phpTestFile = join(directory, "external-http-guardrail.php")
await writeFile(
Expand Down
Loading