Skip to content

Fix configured PHP benchmark workload reuse - #2447

Merged
chubes4 merged 1 commit into
mainfrom
fix/2446-configured-php-workload-reuse
Aug 31, 2026
Merged

Fix configured PHP benchmark workload reuse#2447
chubes4 merged 1 commit into
mainfrom
fix/2446-configured-php-workload-reuse

Conversation

@chubes4

@chubes4 chubes4 commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • load each configured PHP workload file once per benchmark command
  • reuse its returned callable across warmup and measured iterations
  • cover named helper declarations and per-iteration callable execution

Verification

  • npm exec -- tsx tests/bench-command-step-behavior.test.ts
  • npm run build
  • git diff --check

Fixes #2446.

AI assistance

GPT-5.6 Sol via OpenCode diagnosed the configured-workload lifecycle mismatch from retained homeboy-lab evidence, implemented the focused repair and regression coverage under Chris Huber’s direction, and ran the listed verification.

@chubes4
chubes4 marked this pull request as ready for review August 31, 2026 18:02
@chubes4
chubes4 merged commit a34c5e9 into main Aug 31, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configured PHP benchmark workloads reload files on every iteration

1 participant