Skip to content

Integrating sphere multiplication factor did not decrease when more output ports are opened #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oczoske merged 1 commit into from
Oct 22, 2026
Merged

Integrating sphere multiplication factor did not decrease when more output ports are opened #1051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scopesim/effects/metis_wcu/metis_wcu.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,7 @@ def is_multiplication(self, wavelength, nport=2):
area_out = (self.d_is_out**2
* (1 - np.cos(np.arcsin(self.d_is_out / self.d_is))))
area_is = np.pi * self.d_is**2
if nport == 0:
if nport > 0:
frac = ((area_in + (nport - 1) * area_out) / area_is).decompose().value
else:
frac = 0
Expand Down
7 changes: 7 additions & 0 deletions scopesim/tests/tests_effects/test_MetisWCU.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,13 @@ def test_bb_aperture_does_not_change_background_emission(self, bbsource,
bbsource.set_bb_aperture(newvalue)
npt.assert_equal(bbsource.intens_bg, ref_bg)

def test_open_is_ports_decrease_multiplication(self, bbsource):
lam = 5 * u.um
nports = np.arange(1, 10)
is_mult = [bbsource.is_multiplication(lam, nport)
for nport in nports]
assert np.all(np.diff(is_mult) < 0)

def test_laser_brighter_with_fibre_transmission(self, bbsource):
bbsource.set_lamp("laser")
ft_1 = bbsource.fibre_trans
Expand Down
Loading