Skip to content

Integrating sphere multiplication factor did not decrease when more output ports are opened - #1051

Merged
oczoske merged 1 commit into
mainfrom
oc/int_sphere_nports
Oct 22, 2026
Merged

oczoske merged 1 commit into
mainfrom
oc/int_sphere_nports

Conversation

@oczoske

@oczoske oczoske commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator

This is an embarrassing little bug reported by functional Giannis (METIS AIT). The reason was a simple Boolean condition that was written the wrong way round.

@oczoske
oczoske requested a review from teutoburg October 22, 2026 05:29
@oczoske oczoske self-assigned this Oct 22, 2026
@oczoske oczoske added bugfix PR resolving one or more bugs (use "Bug" type for issues, not this label) METIS AIT Issues relating to METIS AIT simulations labels Oct 22, 2026
@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.56%. Comparing base (2d24516) to head (824584f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1051      +/-   ##
==========================================
- Coverage   74.87%   72.56%   -2.32%     
==========================================
  Files          70       70              
  Lines        9003     9003              
==========================================
- Hits         6741     6533     -208     
- Misses       2262     2470     +208     
Flag Coverage Δ
offline 72.56% <100.00%> (ø)
webtests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@oczoske
oczoske merged commit 049dfde into main Oct 22, 2026
31 of 39 checks passed
@oczoske
oczoske deleted the oc/int_sphere_nports branch October 22, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix PR resolving one or more bugs (use "Bug" type for issues, not this label) METIS AIT Issues relating to METIS AIT simulations

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants