Repository navigation
tui3, manual: a question's own answer box answers to the whole caret vocabulary - #1032
Closed
santoshkumarradha wants to merge 1 commit into
Closed
santoshkumarradha wants to merge 1 commit into
santoshkumarradha wants to merge 1 commit into
Conversation
…vocabulary `questionOtherKey` routed keys by hand and bound a short list, so in a question's own answer box the usual text-editing keys did nothing: cmd-left/right never reached the ends of the line, cmd-delete never killed to the line start, and opt-delete/ctrl-delete never deleted a word — while the message box directly beneath the question answered to every one of them. The box now reads the surface's one word-and-line vocabulary (`editorMotion`/`editorWordKill`, editkeys.go) the way every other box does, and gains the line kill's two names (`ctrl+u`, `super+backspace`). `ctrl+w` stays out on purpose: it shuts the tab in front. The manual gains the box on the list of boxes that answer the caret vocabulary, `questions.md` says so at the `something else…` row, and a new test walks every chord family through the row's own box. Co-Authored-By: aforge <[email protected]>
|
|
Member
Author
|
Merged into the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1013.
questionOtherKeyrouted keys by hand and bound a short list, so in a question's own answer box the usual text-editing keys did nothing:cmd+←/cmd+→never reached the ends of the line,cmd+deletenever killed to the line start, andopt+delete/ctrl+deletenever deleted a word — while the message box directly beneath the question answered to every one of them.The row now reads the surface's one word-and-line vocabulary (
editorMotion/editorWordKillininternal/tui3/editkeys.go), the same door every other box on the surface goes through, and gains the line kill's two names (ctrl+u,super+backspace).ctrl+wstays out on purpose: on this surface it shuts the tab in front.internal/tui3/question.go— the routing; the hand-rolled chord list is gone.internal/tui3/question_test.go— a new test walks every chord family (cmd/super/opt/ctrl + ←→,ctrl+a/ctrl+e,ctrl+u, cmd/opt/ctrl+delete) through the row's own box, asserts the edit is not reaching the message box, and checks the edited words still travel as the answer.internal/manual/chat/keys.md+questions.md— the box is now on the list of boxes that answer the caret vocabulary (the manual law).Checks
go test ./internal/tui3/ -run Question— passes.pr-readylight gate passed whole (build, vet, fmt, changelog, manual gates, laws, every package). Its heavy half (test-touched→./internal/tui3) refused to start because another session holds the box's heavy-suite lock (pid 94903); the focused-run Questionrun above is the evidence for the touched package.Drafted with agentfield ai · reviewed and owned by the author