Repository navigation
tui3: a question's own answer box reads the shared editing vocabulary (#1013) - #1031
Closed
santoshkumarradha wants to merge 1 commit into
Closed
santoshkumarradha wants to merge 1 commit into
santoshkumarradha wants to merge 1 commit into
Conversation
…#1013) The `something else…` row is a box — the one place on a question a person types an answer of their own — and `questionOtherKey` routed its keys by hand, binding only a short list. So `cmd+←`/`cmd+→` never reached the ends of the line, `cmd+delete` never killed to the line's start, and `opt+delete`/`ctrl+delete` never deleted a word: the chords worked in the message box under the answer and were silently dead IN the answer. It is the defect editkeys.go was written for, said about a box that had grown its own map. The motions now go through `editorMotion` and the word kill through `editorWordKill`, and kill-to-start is read under the two names the message box binds (`ctrl+u`, `super+backspace`). `ctrl+w` stays the tab close it is everywhere else. - internal/tui3/question.go: replace the hand-rolled motion/word-kill cases with the shared vocabulary; add the line kill. - internal/tui3/questionchords_test.go: the answers box takes the three word names, the two line-end names and both word kills; red before the fix. - internal/manual/chat/questions.md: the box's paragraph says what its editing keys do. - docs/changes/unreleased/1013-question-answer-box-chords.md. Co-Authored-By: aforge <[email protected]>
|
|
Member
Author
|
Closing as a duplicate of #1032. Both fix #1013 (a question's own answer box not reading the shared caret vocabulary); the fix is the same shared-vocabulary change in internal/tui3/question.go. #1032 is the later commit (09:04 vs 09:01 on the same day) and also updates keys.md, so it is the one kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1013.
The
something else…row is a box — the one place on a question a person typesan answer of their own — and
questionOtherKeyrouted its keys by hand, bindingonly a short list. So
cmd+←/cmd+→never reached the ends of the line,cmd+deletenever killed to the line's start, andopt+delete/ctrl+deletenever deleted a word: the chords worked in the message box under the answer and
were silently dead in the answer. It is the defect
editkeys.gowas written for,said about a box that had grown its own map.
Fix. The motions now go through
editorMotionand the word kill througheditorWordKill— the one vocabulary every other box on the surface reads — andkill-to-start is read under the two names the message box already binds
(
ctrl+u,super+backspace).ctrl+wis deliberately still not the word killhere: it shuts the tab in front everywhere on this surface, the same bargain the
message box makes.
internal/tui3/question.go— replace the hand-rolled motion/word-kill caseswith the shared vocabulary; add the line kill.
internal/tui3/questionchords_test.go— the answer box takes the three wordnames, the two line-end names, and both word kills. Red before the fix
(
ctrl+left was not taken…,ctrl+u did not kill…), green after.internal/manual/chat/questions.md— the box's paragraph now says what itsediting keys do (the manual law).
docs/changes/unreleased/1013-question-answer-box-chords.md.Verified.
go test ./internal/tui3/ -run Questionpasses;make test-quick(build, vet, fmt, packed corpus, changelog, manual gates, laws — the whole tree)
is green.
Drafted with agentfield ai · reviewed and owned by the author