Fix async/event lifecycle edge cases - #687
Conversation
39cf3cf to
1f15a84
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #687 +/- ##
==========================================
- Coverage 97.51% 97.51% -0.01%
==========================================
Files 62 62
Lines 10949 10947 -2
==========================================
- Hits 10677 10675 -2
Misses 272 272 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
for:
Is this one we were preventing propagation of on purpose? |
|
Closing as superseded by the refreshed #829. That PR focuses on the demonstrated event bugs: once-listeners firing more than once and callback-returned awaitables being ignored. The unrelated periodic-cancellation and zero-limit changes from this older PR were not retained because the review did not establish a current need for them. |
Summary
Fixes async lifecycle edge cases in concurrency limiting, periodic polling cancellation, and async event listener handling.
Failing tests addressed
tests/test_async_.py::test_gather_with_limited_concurrency_zero_limit_rejectedtests/test_async_.py::test_periodic_cancellation_propagatestests/test_event.py::test_event_base_once_async_multiple_emits_same_ticktests/test_event.py::test_event_base_emit_async_callable_objectVerification
pytest(branch-local targeted run): all listed tests pass.